Implement an rdf command for converting into JSON-LD#791
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
rdf command for converting into JSON-LDrdf command for converting into JSON-LD
🤖 Augment PR SummarySummary: This PR introduces a new Changes:
Technical Notes: The 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
3 issues found across 86 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/rdf/fail_compact_context_invalid_json.sh">
<violation number="1" location="test/rdf/fail_compact_context_invalid_json.sh:27">
P3: Each test run should capture **both** stdout and stderr so the unused stream is verified empty. In the text-variant run (line 27–29), stderr is captured but stdout is not; if an accidental log line or summary reaches stdout, the test won't catch it. In the JSON-variant run (line 39–42), stdout with `--json` is captured but stderr is not; text leaking to stderr alongside the JSON output would go undetected. Recommendation: redirect the unused stream to a separate file and assert it is empty, or use a helper that captures both.</violation>
</file>
<file name="test/rdf/pass_keyword_type.sh">
<violation number="1" location="test/rdf/pass_keyword_type.sh:33">
P1: The expected `@type` array has the IRIs in reverse order compared to the schema's `x-jsonld-type`. The schema specifies `["https://schema.org/Person", "https://schema.org/Agent"]` (Person first), but the expected output lists Agent first. The implementation in `vendor/blaze/src/output/output_jsonld.cc` preserves insertion order via `push_back` without sorting, so this test will fail on `diff`.</violation>
</file>
<file name="test/rdf/pass_keyword_container_index.sh">
<violation number="1" location="test/rdf/pass_keyword_container_index.sh:18">
P1: Expected output silently drops the object keys ("a", "b") which should be preserved as `@index` values per `@container: @index` semantics. In JSON-LD, `@container: @index` means the keys of the source object map to `@index` properties on each entry — analogous to how `@language` maps keys to `@language` in `pass_keyword_container_language.sh`. Without the `@index` field, the output loses the identity of each indexed entry.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jul 9, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v16.0.0` → `v16.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v16.1.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v16.1.0) [Compare Source](sourcemeta/jsonschema@v16.0.0...v16.1.0) #### What's Changed - Update the README banner by [@​jviotti](https://github.com/jviotti) in [#​783](sourcemeta/jsonschema#783) - Rename `SOURCEMETA_JSONSCHEMA_CURL_SO` to `SOURCEMETA_CORE_CURL_SO` by [@​jviotti](https://github.com/jviotti) in [#​784](sourcemeta/jsonschema#784) - Fix some validation edge cases due to over optimisations in `validate --fast` by [@​jviotti](https://github.com/jviotti) in [#​785](sourcemeta/jsonschema#785) - Fix YAML syntax errors not properly caught by [@​jviotti](https://github.com/jviotti) in [#​787](sourcemeta/jsonschema#787) - Various minor fixes and performance optimisations by [@​jviotti](https://github.com/jviotti) in [#​790](sourcemeta/jsonschema#790), [#​789](sourcemeta/jsonschema#789), [#​788](sourcemeta/jsonschema#788), and [#​786](sourcemeta/jsonschema#786) - Implement an `rdf` command for converting into JSON-LD by [@​jviotti](https://github.com/jviotti) in [#​791](sourcemeta/jsonschema#791) **Full Changelog**: <sourcemeta/jsonschema@v16.0.0...v16.1.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com