Upgrade Sourcemeta dependencies#789
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the repository’s vendored Sourcemeta dependencies (Core/Blaze/JsonBinPack) to newer revisions and aligns local build integration with those upstream changes. Changes:
Notes: The large diff is primarily upstream vendored code churn (including removal of vendored GoogleTest sources). 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| auto print_diagnostic(std::string_view message) -> void { | ||
| std::size_t start{0}; | ||
| while (start <= message.size()) { |
There was a problem hiding this comment.
vendor/core/src/lang/test/test.cc:48: while (start <= message.size()) will emit an extra empty # diagnostic line if message ends with a trailing newline (since start reaches message.size()). Consider tightening the loop condition so the final iteration doesn’t print a zero-length line.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| return; | ||
| } | ||
|
|
||
| found = true; |
There was a problem hiding this comment.
vendor/core/src/core/http/cache_control_max_age.cc:32: found is set before validating the parsed max-age value, so a malformed first max-age directive prevents considering any subsequent valid max-age directives in the same header value. Consider only setting found after parsing succeeds (or documenting that a malformed first directive invalidates the whole header).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v16.0.0` → `v16.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v16.1.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v16.1.0) [Compare Source](sourcemeta/jsonschema@v16.0.0...v16.1.0) #### What's Changed - Update the README banner by [@​jviotti](https://github.com/jviotti) in [#​783](sourcemeta/jsonschema#783) - Rename `SOURCEMETA_JSONSCHEMA_CURL_SO` to `SOURCEMETA_CORE_CURL_SO` by [@​jviotti](https://github.com/jviotti) in [#​784](sourcemeta/jsonschema#784) - Fix some validation edge cases due to over optimisations in `validate --fast` by [@​jviotti](https://github.com/jviotti) in [#​785](sourcemeta/jsonschema#785) - Fix YAML syntax errors not properly caught by [@​jviotti](https://github.com/jviotti) in [#​787](sourcemeta/jsonschema#787) - Various minor fixes and performance optimisations by [@​jviotti](https://github.com/jviotti) in [#​790](sourcemeta/jsonschema#790), [#​789](sourcemeta/jsonschema#789), [#​788](sourcemeta/jsonschema#788), and [#​786](sourcemeta/jsonschema#786) - Implement an `rdf` command for converting into JSON-LD by [@​jviotti](https://github.com/jviotti) in [#​791](sourcemeta/jsonschema#791) **Full Changelog**: <sourcemeta/jsonschema@v16.0.0...v16.1.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Signed-off-by: Juan Cruz Viotti jv@jviotti.com