Upgrade all dependencies#788
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the repository’s pinned dependency SHAs (core/jsonbinpack/blaze and the JSON Schema Test Suite) to newer upstream revisions. Changes:
Technical Notes: Several of the changes are in vendored dependencies and may alter public APIs/behavior (e.g., JSON Pointer concatenation and new JSON-LD/JOSE surface area). 🤖 Was this summary useful? React with 👍 or 👎 |
| const std::optional<std::string_view> expected_subject, | ||
| const std::optional<std::string_view> expected_type) | ||
| -> std::optional<JWTVerificationError> { | ||
| const auto now{this->clock_()}; |
There was a problem hiding this comment.
JWKSProvider::verify calls the injected clock_() without any exception guard, so a throwing test/consumer clock would escape verify() (unlike the fetcher which is explicitly contained). Consider whether verify() should treat a throwing clock as a failed verification path to keep its “never escape verification” resilience story consistent.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| -> JSON { | ||
| // Compaction operates on input already in expanded document form. Callers | ||
| // that hold a non-expanded document expand it first. | ||
| assert(jsonld_is_expanded(input)); |
There was a problem hiding this comment.
These are exported entry points, but assert(jsonld_is_expanded(input)) means release builds will accept non-expanded input and continue with potentially nonsensical results instead of failing fast. Consider whether this should be a runtime check/error (or at least explicitly documented as undefined behavior) to avoid surprising production behavior.
Severity: medium
Other Locations
vendor/core/src/core/jsonld/jsonld.cc:141
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v16.0.0` → `v16.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v16.1.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v16.1.0) [Compare Source](sourcemeta/jsonschema@v16.0.0...v16.1.0) #### What's Changed - Update the README banner by [@​jviotti](https://github.com/jviotti) in [#​783](sourcemeta/jsonschema#783) - Rename `SOURCEMETA_JSONSCHEMA_CURL_SO` to `SOURCEMETA_CORE_CURL_SO` by [@​jviotti](https://github.com/jviotti) in [#​784](sourcemeta/jsonschema#784) - Fix some validation edge cases due to over optimisations in `validate --fast` by [@​jviotti](https://github.com/jviotti) in [#​785](sourcemeta/jsonschema#785) - Fix YAML syntax errors not properly caught by [@​jviotti](https://github.com/jviotti) in [#​787](sourcemeta/jsonschema#787) - Various minor fixes and performance optimisations by [@​jviotti](https://github.com/jviotti) in [#​790](sourcemeta/jsonschema#790), [#​789](sourcemeta/jsonschema#789), [#​788](sourcemeta/jsonschema#788), and [#​786](sourcemeta/jsonschema#786) - Implement an `rdf` command for converting into JSON-LD by [@​jviotti](https://github.com/jviotti) in [#​791](sourcemeta/jsonschema#791) **Full Changelog**: <sourcemeta/jsonschema@v16.0.0...v16.1.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTYuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Signed-off-by: Juan Cruz Viotti jv@jviotti.com