fix: don't print credentials to stdout on login unless --no-cache#8
Merged
Conversation
login always dumped credentials to stdout, which leaks them during demos. Now the default path caches silently and points the user at `source-coop creds`; stdout output only happens with --no-cache, where nothing is cached and printing is the only way to get the creds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
source-coop loginalways printed the resolved AWS credentials to stdout, regardless of--no-cache. During demos this leaks credentials onto the terminal/recording every time.Change
Credentials now go to stdout only when
--no-cacheis passed:source-coop login→ caches silently, no creds on stdout, printsRun 'source-coop creds' to print them.source-coop login --no-cache→ prints creds to stdout (nothing is cached, so output is the only way to get them)source-coop creds→ unchangedThis matches the
--no-cacheflag's existing doc comment ("just print to stdout") and the separatecredscommand whose job is printing.Test
No tests in this repo and the change is a branch swap; verified with
cargo buildandcargo fmt --check.🤖 Generated with Claude Code