Add GPX journey recording - #298
Draft
RDMurray wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Soundscape users need a reliable way to record journeys as portable GPX tracks without leaving the app. Draft persistence protects an in-progress recording from interruption, while local and iCloud destinations make completed tracks easy to access and share.
The storage follow-up keeps paired-device data, experiment controls, and Shared Experiences content/state private after enabling document sharing. A synchronous starting state also closes the repeated-Start race that could recreate and truncate an active draft.
User impact
Users can start and stop recording from the main menu, see recording status and point counts, recover interrupted recordings, choose a safe unique filename, and share saved tracks. iCloud recordings appear in Files when iCloud Drive is available, with local fallback and retry options for cloud failures.
Validation
xcodebuild test -project GuideDogs.xcodeproj -scheme Soundscape -destination 'platform=iOS Simulator,id=6D13394A-295B-4D57-B202-561E1E914E74' -only-testing:'UnitTests/GPXRecordingTests' CODE_SIGNING_ALLOWED=NOplutil -lintpassed for Info.plist, Soundscape.entitlements, and project.pbxprojgit diff --checkpassed