Log of Changes #178
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,61 @@ | ||
| name: "build and submit to testflight" | ||
| on: | ||
| workflow_run: | ||
| workflows: | ||
| - "ios-tests" | ||
| types: | ||
| - completed | ||
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
| permissions: | ||
| contents: write | ||
| jobs: | ||
| build-and-upload: | ||
| if: ${{ github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' }} | ||
| runs-on: macos-14 | ||
| environment: Production | ||
|
|
||
| steps: | ||
| # Check out code with push permissions (needed for commit) | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: true | ||
|
|
||
| - name: Bump build number | ||
| run: | | ||
| cd apps/ios | ||
| agvtool bump | ||
|
|
||
| # Commit and push the version change (avoid loop with [skip ci]) | ||
| - name: Commit bump | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git add -A | ||
| git commit -m "chore(ci): bump build number [skip ci]" || echo "Nothing to commit" | ||
| git push | ||
|
|
||
| # 4 Select the latest stable Xcode version | ||
| - uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: "latest-stable" | ||
|
|
||
| # install the developer certificate in the signing_temp keychain | ||
| - name: install certificate | ||
| id: install-certificates | ||
| uses: apple-actions/import-codesign-certs@v3 | ||
| with: | ||
| p12-file-base64: ${{ secrets.APPSTORE_CERTIFICATES_FILE_BASE64 }} | ||
| p12-password: ${{ secrets.APPSTORE_CERTIFICATES_PASSWORD }} | ||
|
|
||
| - name: build and upload to testflight | ||
| env: | ||
| APPSTORE_CONNECT_API_KEY: ${{ secrets.APP_STORE_P8_BASE64 }} | ||
| APPSTORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_ISSUER_ID }} | ||
| APPSTORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_KEY_ID }} | ||
| KEYCHAIN_PASSWORD: ${{ steps.install-certificates.outputs.keychain-password }} | ||
| run: "apps/ios/Scripts/ci/archive-upload.sh | xcpretty && exit ${PIPESTATUS[0]}" | ||
|
Comment on lines
+55
to
+61
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result:
Sources: Citations: Install This workflow pipes to Code snippetAdd a step to install xcpretty (e.g., 🧰 Tools🪛 actionlint (1.7.11)[error] 61-61: shellcheck reported issue in this script: SC2086:info:1:58: Double quote to prevent globbing and word splitting (shellcheck) 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,7 @@ | |
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| enableThreadSanitizer = "YES" | ||
|
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: # Check if the file exists and examine its structure
if [ -f "apps/ios/GuideDogs.xcodeproj/xcshareddata/xcschemes/Soundscape.xcscheme" ]; then
echo "=== File exists ==="
# Get context around line 82
sed -n '75,90p' "apps/ios/GuideDogs.xcodeproj/xcshareddata/xcschemes/Soundscape.xcscheme"
echo -e "\n=== Full LaunchAction section ==="
# Try to find the LaunchAction context
sed -n '/<LaunchAction/,/<\/LaunchAction>/p' "apps/ios/GuideDogs.xcodeproj/xcshareddata/xcschemes/Soundscape.xcscheme" | head -40
else
echo "File not found"
fiRepository: soundscape-community/soundscape Length of output: 2240 🏁 Script executed: # Check if there are other schemes in the directory
ls -la "apps/ios/GuideDogs.xcodeproj/xcshareddata/xcschemes/" 2>/dev/null || echo "Directory not found"Repository: soundscape-community/soundscape Length of output: 593 🌐 Web query:
💡 Result: Apple introduced Thread Sanitizer (TSan) for Xcode/iOS at WWDC 2016, and explicitly noted that TSan is not supported on physical iOS devices—it’s intended for use in the iOS Simulator (and other supported simulated environments). [1], [2] Apple has expanded TSan’s simulator coverage over time (for example, Xcode 12 added TSan when debugging on simulated watchOS devices), but that does not change iOS on-device support. [3] Bottom line: No—TSan does not support running on an iPhone/iPad device; use the iOS Simulator. [1], [2] Sources: 🌐 Web query:
💡 Result:
Sources: Citations:
Move Thread Sanitizer to a debug-only scheme. This scheme is checked in under 🤖 Prompt for AI Agents |
||
| launchStyle = "0" | ||
| useCustomWorkingDirectory = "NO" | ||
| ignoresPersistentStateOnLaunch = "NO" | ||
|
|
@@ -102,6 +103,13 @@ | |
| isEnabled = "YES"> | ||
| </EnvironmentVariable> | ||
| </EnvironmentVariables> | ||
| <AdditionalOptions> | ||
| <AdditionalOption | ||
| key = "NSZombieEnabled" | ||
| value = "YES" | ||
| isEnabled = "YES"> | ||
| </AdditionalOption> | ||
| </AdditionalOptions> | ||
| <LocationScenarioReference | ||
| identifier = "com.apple.dt.IDEFoundation.CurrentLocationScenarioIdentifier" | ||
| referenceType = "1"> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| <body> | ||
| <h1>MIT License</h1> | ||
| <p> | ||
| Copyright © 2026 Soundscape Community Contributors | ||
| <br/> | ||
| Copyright © Microsoft Corporation. | ||
| </p> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
For a GitHub Actions workflow triggered byworkflow_run, what ref/commit doesactions/checkout@v4use by default, and how do you explicitly check outgithub.event.workflow_run.head_sha?💡 Result:
By default,
actions/checkout@v4checks out the ref/SHA that triggered the current workflow run (i.e., effectivelygithub.ref/github.sha), otherwise it falls back to the repo’s default branch. [1]For workflows triggered by
workflow_run, that typically means you’ll end up on the default branch commit for theworkflow_run-triggered workflow, not the commit that the upstream workflow ran on (this is part of GitHub’s “run from default branch for certain events” behavior). [2]To explicitly check out the triggering workflow’s commit, use the
workflow_runpayload’shead_sha(the workflow-run object includeshead_sha). [3]Sources: [1] [2] [3]
🏁 Script executed:
cat -n .github/workflows/build-for-testflight.yml | head -30Repository: soundscape-community/soundscape
Length of output: 930
Checkout should be pinned to the triggering SHA.
For
workflow_run, this job builds the commit that passedios-tests. Without an explicitref, a later push tomainwill make this workflow archive and upload untested code instead.Suggested fix
- uses: actions/checkout@v4 with: + ref: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_sha || github.sha }} fetch-depth: 0 persist-credentials: true🤖 Prompt for AI Agents