Setup process startup and Settings page continuation#131
Open
MBtheOtaku wants to merge 8 commits into
Open
Conversation
steinbro
requested changes
Dec 15, 2024
steinbro
left a comment
steinbro
left a comment
Member
There was a problem hiding this comment.
Thanks! I think there's still some work to be done here; I've left a few comments.
Comment on lines
+70
to
+79
| private static let sectionDescriptions: [Section: String] = [ | ||
| .general: "General settings for the app.", | ||
| .audio: "Control how audio interacts with other media.", | ||
| .beacon: "Settings for beacon management.", | ||
| .callouts: "Manage the callouts that help navigate.", | ||
| .streetPreview: "Settings for including unnamed roads.", | ||
| .troubleshooting: "Options for troubleshooting the app.", | ||
| .about: "Information about the app.", | ||
| .telemetry: "Manage data collection and privacy." | ||
| ] |
Member
Comment on lines
+82
to
+85
| // Mocked UserSettings for demonstration purposes | ||
| struct UserSettings { | ||
| static var alwaysShowLanguageSelection: Bool = false // User-configurable setting | ||
| } |
Member
There was a problem hiding this comment.
If this is meant to be a user-configurable setting, this would need to be propagated to a settings view. But per #112 I think we just wanted to change the heuristic for when the language choice should be shown, not add another setting.
Comment on lines
+70
to
+80
| private func checkAudioStatus() { | ||
| // Here, implement the functionality to check audio status. | ||
| // This could involve presenting an alert or a new screen with audio information. | ||
| let alert = UIAlertController( | ||
| title: GDLocalizedString("troubleshooting.check_audio"), | ||
| message: GDLocalizedString("troubleshooting.check_audio.explanation"), | ||
| preferredStyle: .alert | ||
| ) | ||
| alert.addAction(UIAlertAction(title: GDLocalizedString("general.alert.ok"), style: .default)) | ||
| present(alert, animated: true) | ||
| } |
Member
There was a problem hiding this comment.
Is this presenting an alert, without actually doing the requested action?
Comment on lines
+96
to
+107
| private func clearMapData() { | ||
| // Logic to clear stored map data goes here | ||
| // For example, removing cached files or data from UserDefaults if relevant. | ||
| // Notify the user after clearing data. | ||
| let confirmationAlert = UIAlertController( | ||
| title: GDLocalizedString("settings.clear_cache.alert_title"), | ||
| message: GDLocalizedString("settings.clear_cache.no_service.message"), | ||
| preferredStyle: .alert | ||
| ) | ||
| confirmationAlert.addAction(UIAlertAction(title: GDLocalizedString("general.alert.ok"), style: .default)) | ||
| present(confirmationAlert, animated: true) | ||
| } |
Member
There was a problem hiding this comment.
Same as checkAudioStatus, I'm not seeing the logic to actually perform the action here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally carried over my work from the IOS settings page work into a new branch and thus into this pull request but there is also some work done for the setup process startup issue that can be looked at, not entirely sure if it works 100%. More changes may have to be made.