Skip to content

Skip Github Action if there is no branch specified#134

Open
vatanaksoytezer wants to merge 2 commits into
sorenlouv:mainfrom
vatanaksoytezer:vatan/no_branch
Open

Skip Github Action if there is no branch specified#134
vatanaksoytezer wants to merge 2 commits into
sorenlouv:mainfrom
vatanaksoytezer:vatan/no_branch

Conversation

@vatanaksoytezer

Copy link
Copy Markdown

Hey, thank you so much for this tool! #127 was getting a bit annoying for us. So this should address #127 by skipping the action (and issue a warning) if it is just a no-branch issue. Please let me know if you want it to be implemented any other way. Thank you!

@vatanaksoytezer vatanaksoytezer changed the title Vatan/no branch Skip Github Action if there is no branch specified Jul 8, 2024
@sorenlouv

Copy link
Copy Markdown
Owner

Hey! Thanks for opening the PR. Sorry for not having the time to review it until now.
Was there a problem with this or why did you close?

@e3l

e3l commented Jul 16, 2024

Copy link
Copy Markdown

i think this was accidentally automatically closed due to activity in another (private) repository. would be awesome if we could re-open and get reviewed/merged!

@jfagoagas

Copy link
Copy Markdown

Merging this would be ideal to fix that issue, because it super annoying to have failed actions when the PR don't need to be backported @sorenlouv.

Thanks for the fix @e3l 👏

@vatanaksoytezer

Copy link
Copy Markdown
Author

Hey @sorenlouv sorry I was away for a while. Re opened the issue. Please feel free to merge or request any changes and will do asap. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants