Feature/ft categories on off setup#12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 0 of the
ft-categories-on-offfeature — library integration and configuration. Adds thefeature-gate-middlewarelibrary with GitHub Packages authentication, configures feature flag properties, and creates a FakeFeatureFlagClient for offline testing without ConfigCat SDK key.Changes
Configuration
feature-gate-middlewaredependency (0.1.0-SNAPSHOT), andspring-boot-starter-actuatorfor Micrometer metricsfeature-gate.configcat.sdk-key,feature-gate.watch.enabled, andfeature-gate.hi.enabledpropertiesGITHUB_TOKENenvironment variable to test job for GitHub Packages authenticationTest Infrastructure
FeatureFlagClientbacked byMap<String, Boolean>for offline testing@Primarybean@Import(FeatureFlagTestConfiguration.class)and@ActiveProfiles("test")Notes
io.architecture.featureflag.corepackage, notio.featuregate.coreas initially documented in the specfeature-gate-middlewaredependency scope set tocompileto make API classes available for test compilation (library POM has all dependencies asruntime)spring-boot-starter-actuatorto provideMeterRegistrybean required bywatchFeatureFlagAspectConfigCatFeatureFlagClientin test contextChecklist