Skip to content

use less specific argument type #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miken32 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use less specific argument type #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/X509/Certificate/TBSCertificate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Sop\CryptoBridge\Crypto;
use Sop\CryptoTypes\AlgorithmIdentifier\AlgorithmIdentifier;
use Sop\CryptoTypes\AlgorithmIdentifier\Feature\SignatureAlgorithmIdentifier;
use Sop\CryptoTypes\Asymmetric\PrivateKeyInfo;
use Sop\CryptoTypes\Asymmetric\OneAsymmetricKey;
use Sop\CryptoTypes\Asymmetric\PublicKeyInfo;
use Sop\X501\ASN1\Name;
use Sop\X509\Certificate\Extension\AuthorityKeyIdentifierExtension;
Expand Down Expand Up @@ -524,11 +524,11 @@ public function toASN1(): Sequence
* Create signed certificate.
*
* @param SignatureAlgorithmIdentifier $algo Algorithm used for signing
* @param PrivateKeyInfo $privkey_info Private key used for signing
* @param OneAsymmetricKey $privkey_info Private key used for signing
* @param null|Crypto $crypto Crypto engine, use default if not set
*/
public function sign(SignatureAlgorithmIdentifier $algo,
PrivateKeyInfo $privkey_info, ?Crypto $crypto = null): Certificate
OneAsymmetricKey $privkey_info, ?Crypto $crypto = null): Certificate
{
$crypto = $crypto ?? Crypto::getDefault();
$tbs_cert = clone $this;
Expand Down