Support OTN attenuator and amplifier#5
Conversation
Add support for OTN attenuator and amplifier based on OCP SAI PR #2217.
|
Would you like to raise a PR to https://github.com/sonic-net/sonic-swss-common? |
|
Yes. After team review, I will merge it into sonic-otn otn_pr branch, then submit a pr to sonic-net. |
| #define CHASSIS_APP_LAG_TABLE_NAME "SYSTEM_LAG_TABLE" | ||
| #define CHASSIS_APP_LAG_MEMBER_TABLE_NAME "SYSTEM_LAG_MEMBER_TABLE" | ||
|
|
||
| #define CFG_OTN_ATTENUATOR_TABLE_NAME "OTN_ATTENUATOR" |
There was a problem hiding this comment.
as mentioned in comment in line 351 in this file, should we add CFG_* tables here? We don't have plans to add sonic native yang for OTN?
(sorry if i missed this context in any community meeting)
There was a problem hiding this comment.
For OTN, we use openconfig yang, not sonic yang. This is good point. Seems this won't pass the CI pipe line prevent-cfg.yml. looks like we have to add sonic yang on yang-models folder.
There was a problem hiding this comment.
Added sonic yang to auto generate config DB tables name OTN_OA and OTN_ATTENUATOR.
sonic-otn/sonic-buildimage#29
And removed them from schema.h
@ImAmanTanwar @accelinkotn @sonic-otn @iknownothing13, can you approve it, if it is ok with you?
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@qiluo-msft FYI, The PR submitted to the upstream. sonic-net#1223 |
6 participants
Add support for OTN attenuator and amplifier based on OCP SAI PR #2217.