[202605][intfsorch]Fix race condition between VRF bind and ip address removal#4778
Open
dgsudharsan wants to merge 2 commits into
Open
[202605][intfsorch]Fix race condition between VRF bind and ip address removal#4778dgsudharsan wants to merge 2 commits into
dgsudharsan wants to merge 2 commits into
Conversation
… removal (sonic-net#4758) * [intfsorch]Fix race condition between VRF bind and ip address removal Signed-off-by: dgsudharsan <sudharsand@nvidia.com> * Changing log level as per review feedback Signed-off-by: dgsudharsan <sudharsand@nvidia.com> --------- Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #4758
Why I did it
When loopback IP removal and VRF rebind arrive in the same
m_toSyncbatch, the bareinterface key is processed before per-IP keys. The VRF bind is attempted while IPs remain,
logged as an error, and dropped, leaving the interface stuck in the wrong VRF.
Work item tracking
How I did it
when IPs are still present on the interface.
IntfsOrchVrfBindDeferredUntilIpRemovedregression test for the batched IP-removal + VRF-bind race (Redmine #5108427).
How to verify it
IntfsOrchVrfBindDeferredUntilIpRemovedinintfsorch_ut.cpp.Which release branch to backport (provide reason below if selected)
Description for the changelog
[intfsorch]Fix race condition between VRF bind and ip address removal
Summary by CodeRabbit