[ci][DO-NOT-MERGE]: Validate against sonic-swss-common migration (#1222, build 1164874)#4753
Draft
theasianpianist wants to merge 1 commit into
Draft
Conversation
…4 (migration validation) Draft PR to validate that sonic-swss builds + tests green against the sonic-swss-common CI-unification migration PR (sonic-net/sonic-swss-common#1222). Pin every 'Download sonic swss common' step (build-template, build-docker, test-docker) to runVersion: specific / runId: 1164874 (the green sonic-net#1222 build) instead of latestFromBranch on the swss_common_branch parameter. sonic-net#1222's swss-common builds against STOCK apt libnl, so libswsscommon Depends on the stock libnl already present in every sonic-swss build/test/docker environment (the build stage installs it from common-lib; the test host resolves it via apt) -- no SONiC-libnl companion changes are needed here (only the pin). NOT for merge -- the runId pin is temporary; revert to latestFromBranch before merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE — CI validation only
Draft PR to validate that sonic-swss builds and tests green against the
sonic-swss-common CI-unification migration PR (sonic-net/sonic-swss-common#1222).
This draft pins sonic-swss's swss-common download to #1222's green build
1164874so itswhole pipeline (build + docker + VS test) is exercised against the migration artifact (produced
by
buildenv_setup, which also publishesbuild-env/).Changes
Pin every
Download sonic swss commonstep (build-template,build-docker,test-docker) torunVersion: specific/runId: 1164874instead oflatestFromBranchon theswss_common_branchparameter.No libnl companion changes — #1222's swss-common builds against stock apt libnl, so
libswsscommonDepends on the stock libnl already present in every sonic-swss build/test/dockerenvironment (the build stage installs it from common-lib; the test host resolves it via apt).
Not for merge
The
runIdpin is temporary; revert tolatestFromBranch/runBranch: refs/heads/${{ parameters.swss_common_branch }}before merge.