Skip to content

[fdbsyncd]: Make VXLAN FDB delete idempotent #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prsunny merged 2 commits into from
Jun 16, 2026
+6 −2
Merged

[fdbsyncd]: Make VXLAN FDB delete idempotent #4674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22bf07
[fdbsyncd]: Make VXLAN FDB delete idempotent
tahmed-dev Jun 15, 2026
27a8d69
[fdbsyncd]: Address VXLAN delete review comments
tahmed-dev Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fdbsyncd/fdbsync.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ void FdbSync::macDelVxlan(string key)
macDelVxlanDB(key);
m_mac.erase(key);
} else {
SWSS_LOG_ERROR("DEL_KEY %s entry doesn't exist", key.c_str());
SWSS_LOG_DEBUG("DEL_KEY %s ignored; entry is not present in VXLAN FDB cache", key.c_str());
}
}

Expand Down
6 changes: 5 additions & 1 deletion tests/mock_tests/fdbsyncd/fdbsyncd_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,8 +1554,12 @@ TEST_F(FdbSyncdEvpnMhTest, TestMacDelVxlan)

// Now call macDelVxlan which should find and process the entry
m_mockFdbSync.macDelVxlan(key);
ASSERT_EQ(0u, m_mockFdbSync.m_mac.count(key));

// A later kernel delete for the same VXLAN FDB entry is expected after a local MAC wins.
m_mockFdbSync.macDelVxlan(key);
ASSERT_EQ(0u, m_mockFdbSync.m_mac.count(key));

ASSERT_TRUE(true);
}

TEST_F(FdbSyncdEvpnMhTest, TestMacDelVxlanEntryNHG)
Expand Down
Loading