Skip to content

[P4Orch] Add SWSS support for new ACL action to set metered Mcast queue and Ucast queue.#4246

Draft
ksravani-hcl wants to merge 5 commits into
sonic-net:masterfrom
ksravani-hcl:acl_rule_s3
Draft

[P4Orch] Add SWSS support for new ACL action to set metered Mcast queue and Ucast queue.#4246
ksravani-hcl wants to merge 5 commits into
sonic-net:masterfrom
ksravani-hcl:acl_rule_s3

Conversation

@ksravani-hcl

@ksravani-hcl ksravani-hcl commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

What I did
This PR contains,

  1. Adding unique label for SAI POLICER object.
  2. Adding label to uniquely identify acl counters.
  3. Adding SWSS support for new ACL action to set metered Mcast queue.
  4. Adding SWSS support for new ACL action to set metered Ucast queue.

this extended p4orch to support ACL actions for setting metered multicast and unicast QoS queues, including color-aware QoS mapping logic. Integrated NameLabelMapper for ACL counters and policers to ensure unique identification and STATE_DB persistence.

Why I did it
Standardized advanced traffic control actions based on packet color and destination type. Implementing persistent labels ensures that complex hardware states for counters and meters are correctly correlated during warm boot reconciliation, preventing resource duplication.

How I verified it
Validated QoS mapping and label verification with new C++ unit tests and updated P4RT integration tests. Confirmed correct ASIC_DB attribute population and persistence through local builds and full test suite execution.

Details if related
#4176 is the base PR for #4211 & #4246.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Feb 21, 2026

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread orchagent/copporch.cpp Outdated

@yunang-c yunang-c left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 6d010f3 part of this PR? Or has it already been included in a separated PR?

Comment thread orchagent/copporch.cpp Outdated
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

mint570
mint570 previously approved these changes Mar 24, 2026
Comment thread tests/mock_tests/copporch_ut.cpp Outdated
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

mint570
mint570 previously approved these changes Mar 27, 2026
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ksravani-hcl ksravani-hcl changed the title [Generic-P4Orch] Add SWSS support for new ACL action to set metered Mcast queue and Ucast queue. [P4Orch] Add SWSS support for new ACL action to set metered Mcast queue and Ucast queue. May 14, 2026
@ksravani-hcl
ksravani-hcl marked this pull request as draft May 15, 2026 12:08
mint570
mint570 previously approved these changes May 15, 2026
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

mint570
mint570 previously approved these changes Jun 9, 2026
mint570 added 5 commits July 24, 2026 03:54
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
Signed-off-by: SRAVANI KANASANI <kanasanis@google.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants