Event and alarm management: Add tables for event and alarms. by bhaveshdell · Pull Request #852 · sonic-net/sonic-swss-common

bhaveshdell · 2024-01-30T22:34:45Z

Why I did it
This PR contains code changes for providing extension to the Event Framework as specified in the sonic-net/SONiC#1409

How I did it
Followed design specified in sonic-net/SONiC#1409.
Add new tables for events and alarms.

shyam77git · 2024-01-31T20:32:05Z

@bhaveshdell
This seems to be only 1 file change I see in this code PR.
Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

bhaveshdell · 2024-01-31T20:39:55Z

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409

#852
sonic-net/sonic-buildimage#17949

shyam77git · 2024-01-31T21:01:08Z

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409

#852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR?
could you add me as reviewer to them both? Add others too so that review can be expedited

bhaveshdell · 2024-02-02T00:28:27Z

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409
#852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited

@shyam77git Only these 2 PRs. Repo owner can add reviewer.

bhaveshdell · 2024-02-02T05:31:55Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2024-02-02T05:31:57Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2024-02-02T05:32:08Z

Azure Pipelines successfully started running 1 pipeline(s).

shyam77git · 2024-02-04T01:57:01Z

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409
#852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited

@shyam77git Only these 2 PRs. Repo owner can add reviewer.

@prgeor / @zhangyanzhao - please add reviewers to this HLD.
This is a per-requisite for FM infra HLD: sonic-net/SONiC#1527

bhaveshdell · 2024-02-20T20:16:05Z

/azpw run Azure.sonic-swss-common

mssonicbld · 2024-02-20T20:16:08Z

/AzurePipelines run Azure.sonic-swss-common

azure-pipelines · 2024-02-20T20:16:20Z

Azure Pipelines successfully started running 1 pipeline(s).

jeffyin-dell · 2024-02-28T23:34:30Z

@qiluo-msft @liuh-80 @shyam77git Please assign reviewers. Also, the build checks seem to be failing for reasons not related to the changes in this PR. Can you please check?

bhaveshdell · 2024-03-14T17:46:17Z

/azpw run

mssonicbld · 2024-03-14T17:46:20Z

/AzurePipelines run

azure-pipelines · 2024-03-14T17:46:32Z

Azure Pipelines successfully started running 1 pipeline(s).

bhaveshdell · 2024-03-16T17:11:20Z

/azpw run

mssonicbld · 2024-03-16T17:11:22Z

/AzurePipelines run

azure-pipelines · 2024-03-16T17:11:33Z

Azure Pipelines successfully started running 1 pipeline(s).

bhaveshdell · 2024-03-16T21:26:02Z

/azpw run

mssonicbld · 2024-03-16T21:26:04Z

/AzurePipelines run

azure-pipelines · 2024-03-16T21:26:16Z

Azure Pipelines successfully started running 1 pipeline(s).

bhavini-gada · 2024-05-07T20:53:26Z

@qiluo-msft @zbud-msft - Can we please get approval/merge on this PR?

qiluo-msft · 2024-05-07T22:42:21Z

 #define CHASSIS_APP_DB      12
 #define CHASSIS_STATE_DB    13
 #define APPL_STATE_DB       14
+#define EVENT_DB            19


There is some redis configuration

# Set the number of databases. The default database is DB 0, you can select # a different one on a per-connection basis using SELECT <dbid> where # dbid is a number between 0 and 'databases'-1 databases 16

If the max number is less than 19, will your feature work? Could you break the build prcoess if it happen? #Closed

The current max number is set to 100 as part of this change
https://github.com/sonic-net/sonic-buildimage/pull/17161/files#diff-88ce9c28933f9dd9c3009adba8ae67827831c0d7b7ad20c72556ae18b3764931

This feature creates an instance of DB, and the above change to 100 suffices this features requirement.

@qiluo-msft Please approve/merge this PR if no further comments.

Why I did it This PR contains code changes for providing extension to the Event Framework as specified in the sonic-net/SONiC#1409 How I did it Followed design specified in sonic-net/SONiC#1409. Add new tables for events and alarms.

bhaveshdell mentioned this pull request Jan 30, 2024

Event/alarm framework HLD update. Integrate with event producer framework. sonic-net/SONiC#1409

Merged

bhaveshdell force-pushed the eventd-comm branch from 0423020 to 66724db Compare February 21, 2024 23:45

bhaveshdell changed the title ~~Event and alarm management: Add newtables for event and alarms.~~ Event and alarm management: Add tables for event and alarms. Feb 22, 2024

bhaveshdell mentioned this pull request Feb 28, 2024

PR commit check failure: testslibsairedis test failed #860

Open

Add new tables for Event and Alarms.

3de7796

bhaveshdell force-pushed the eventd-comm branch from 66724db to 3de7796 Compare March 12, 2024 20:31

zhangyanzhao requested review from qiluo-msft and shyam77git April 3, 2024 00:11

qiluo-msft requested a review from zbud-msft April 3, 2024 00:25

venkatmahalingam approved these changes May 7, 2024

View reviewed changes

Merge branch 'master' into eventd-comm

1e750af

qiluo-msft reviewed May 7, 2024

View reviewed changes

qiluo-msft approved these changes May 11, 2024

View reviewed changes

qiluo-msft merged commit 0044540 into sonic-net:master May 11, 2024

Uh oh!

Conversation

bhaveshdell commented Jan 30, 2024

Uh oh!

shyam77git commented Jan 31, 2024

Uh oh!

bhaveshdell commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shyam77git commented Jan 31, 2024

Uh oh!

bhaveshdell commented Feb 2, 2024

Uh oh!

bhaveshdell commented Feb 2, 2024

Uh oh!

mssonicbld commented Feb 2, 2024

Uh oh!

azure-pipelines Bot commented Feb 2, 2024

Uh oh!

shyam77git commented Feb 4, 2024

Uh oh!

bhaveshdell commented Feb 20, 2024

Uh oh!

mssonicbld commented Feb 20, 2024

Uh oh!

azure-pipelines Bot commented Feb 20, 2024

Uh oh!

jeffyin-dell commented Feb 28, 2024

Uh oh!

bhaveshdell commented Mar 14, 2024

Uh oh!

mssonicbld commented Mar 14, 2024

Uh oh!

azure-pipelines Bot commented Mar 14, 2024

Uh oh!

bhaveshdell commented Mar 16, 2024

Uh oh!

mssonicbld commented Mar 16, 2024

Uh oh!

azure-pipelines Bot commented Mar 16, 2024

Uh oh!

bhaveshdell commented Mar 16, 2024

Uh oh!

mssonicbld commented Mar 16, 2024

Uh oh!

azure-pipelines Bot commented Mar 16, 2024

Uh oh!

bhavini-gada commented May 7, 2024

Uh oh!

qiluo-msft May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhaveshdell May 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhaveshdell May 10, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bhaveshdell commented Jan 31, 2024 •

edited

Loading

qiluo-msft May 7, 2024 •

edited

Loading

bhaveshdell May 8, 2024 •

edited

Loading