[tokenize] Avoid istringstream in delimiter-based tokenize#1203
Open
Mohxen wants to merge 1 commit into
Open
Conversation
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tokenize(str, token)currently constructs astd::istringstreamfor every call.This is more expensive than needed for splitting a string on a single delimiter,
because it brings in iostream and locale machinery.
This helper is used in SWSS hot paths, including route processing in orchagent.
During route burst profiling, perf showed time in:
swss::tokenizestd::getlinestd::basic_ios::_M_cache_localestd::localestd::vector<std::string>growthoperator newFix
Replace the
istringstream/getlineimplementation with directstd::string::find()/substr()delimiter scanning.This matches the implementation style already used by the limited-token tokenize
overload added in #96, while preserving the observed behavior of the base overload.
Testing
Configured locally with YANG modules disabled:
./autogen.sh ./configure --enable-debug --disable-yangmodules 'CXXFLAGS=-O0 -g'