Skip to content

Teamd unified changes#1186

Open
vrajeshe wants to merge 5 commits into
sonic-net:masterfrom
vrajeshe:teamd-unified
Open

Teamd unified changes#1186
vrajeshe wants to merge 5 commits into
sonic-net:masterfrom
vrajeshe:teamd-unified

Conversation

@vrajeshe

Copy link
Copy Markdown
Contributor

What I did
new cli has been added which allows user to select TeamD design from unified to legacy design and vice cersa

How I did it
How to verify it
CLI Test:Added Test coverage mode CLI

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@prhoskot

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 1186 in repo sonic-net/sonic-swss-common

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@prhoskot

prhoskot commented Jul 7, 2026

Copy link
Copy Markdown

@saiarcot895 These PRs are related to Unified Teamd feature implementation. Could you please help in review and approving it. Thanks!

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@forrestchu
forrestchu self-requested a review July 17, 2026 06:40

@forrestchu forrestchu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

2 similar comments
@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@qiluo-msft

Copy link
Copy Markdown
Contributor

This hardcodes TEAMD into an otherwise fully data-driven generator (everything else is derived from confDbYangMap). Works for one alias, but it does not scale and hides the intent.

Could we express it as an alias map instead?

TABLE_ALIASES = {"TEAMD": ["TEAMD_MODE"]}
...
for alias in TABLE_ALIASES.get(key, []):
    f.write('#define CFG_{}_TABLE_NAME CFG_{}_TABLE_NAME\n'.format(alias, key))

Also worth a short comment noting CFG_TEAMD_MODE_TABLE_NAME is a compat alias pointing at the unified TEAMD table, not a separate table. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants