Teamd unified changes#1186
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Venata Gouri Rajesh Etla <vrajeshe@cisco.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1186 in repo sonic-net/sonic-swss-common |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 These PRs are related to Unified Teamd feature implementation. Could you please help in review and approving it. Thanks! |
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
2 similar comments
|
Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-swss-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
This hardcodes Could we express it as an alias map instead? TABLE_ALIASES = {"TEAMD": ["TEAMD_MODE"]}
...
for alias in TABLE_ALIASES.get(key, []):
f.write('#define CFG_{}_TABLE_NAME CFG_{}_TABLE_NAME\n'.format(alias, key))Also worth a short comment noting |
What I did
new cli has been added which allows user to select TeamD design from unified to legacy design and vice cersa
How I did it
How to verify it
CLI Test:Added Test coverage mode CLI
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)