Skip to content

[ci] Install redis from Debian#1154

Merged
qiluo-msft merged 1 commit into
sonic-net:masterfrom
saiarcot895:fix-redis-python-package-version
Feb 23, 2026
Merged

[ci] Install redis from Debian#1154
qiluo-msft merged 1 commit into
sonic-net:masterfrom
saiarcot895:fix-redis-python-package-version

Conversation

@saiarcot895

Copy link
Copy Markdown
Contributor

For the CI runner, install the python3 redis package from the Ubuntu repos instead of via pip. This has the advantage of the version being fixed for the Debian version the test runner is using.

Also remove some development package installations, which shouldn't be needed for running these tests.

This works around the regression for Unix sockets introduced in redis 7.2.0 (see also redis/redis-py#3957 and redis/redis-py#3957).

For the CI runner, install the python3 redis package from the Ubuntu
repos instead of via pip. This has the advantage of the version being
fixed for the Debian version the test runner is using.

Also remove some development package installations, which shouldn't be
needed for running these tests.

This works around the regression for Unix sockets introduced in redis
7.2.0 (see also redis/redis-py#3957 and redis/redis-py#3957).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Copilot AI review requested due to automatic review settings February 21, 2026 00:39
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Pipelines test template to install the Python redis package from Debian repositories instead of pip, addressing a Unix socket regression in redis-py 7.2.0. The change ensures version stability by using the Debian-packaged version and removes unnecessary development packages that were previously installed for test runs.

Changes:

  • Switch from pip-installed redis package to Debian's python3-redis package for version stability
  • Remove unnecessary development packages (libboost-serialization1.74.0, libboost1.74-dev, libboost-dev) from test environment
  • Add -y flag to apt-get install -f for non-interactive dependency resolution

Comment on lines 90 to 91
net-tools \
bridge-utils \

Copilot AI Feb 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package list contains duplicates: 'net-tools' appears on both line 81 and line 90, and 'bridge-utils' appears on both line 82 and line 91. Consider removing the duplicate entries to keep the dependency list clean and maintainable.

Suggested change
net-tools \
bridge-utils \

Copilot uses AI. Check for mistakes.
@qiluo-msft
qiluo-msft merged commit cfec270 into sonic-net:master Feb 23, 2026
23 checks passed
@saiarcot895
saiarcot895 deleted the fix-redis-python-package-version branch February 23, 2026 16:30
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #1173

@mssonicbld

Copy link
Copy Markdown
Collaborator

@saiarcot895 cherry pick PR didn't pass PR checker after retry. Please help check! Thanks.
#1173

---Powered by SONiC BuildBot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants