Skip to content

Fix saisdkdump profile file handling.#1993

Open
judsonwilson-nvidia wants to merge 4 commits into
sonic-net:masterfrom
judsonwilson-nvidia:fix_saisdkdump_profile
Open

Fix saisdkdump profile file handling.#1993
judsonwilson-nvidia wants to merge 4 commits into
sonic-net:masterfrom
judsonwilson-nvidia:fix_saisdkdump_profile

Conversation

@judsonwilson-nvidia

@judsonwilson-nvidia judsonwilson-nvidia commented Jul 15, 2026

Copy link
Copy Markdown

Why I did it

saisdkdump did not parse the SAI profile file passed with -p: profile_get_value returned the file path for every key, and profile_get_next_value always failed. A new feature on the nvidia-bluefield platform, DASH CT dumps from the SDK in techsupport, needs a profile key (CT_TABLE_DUMP_ENABLE) to reach SAI to trigger the CT dump in the SDK dump.

Work item tracking
  • Microsoft ADO (number only): N/A

How I did it

  • Add ProfileMap (based on saidiscovery) to parse key=value lines, skip comments, and back SAI profile callbacks.
  • Load the profile in saisdkdump before sai_api_initialize; build libsaisdkdump_profile.a.
  • Add gtest coverage in unittest/saisdkdump/ (KV parsing, malformed lines, iterator reset, clear).

How to verify it

./autogen.sh && ./configure --disable-static --disable-python2 --with-sai=vs
make -C saisdkdump libsaisdkdump_profile.a
make -C unittest/saisdkdump check

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411

Tested branch (Please provide the tested image version)

  • master, between 202605–202611

Description for the changelog

Fix saisdkdump profile file flag.

@judsonwilson-nvidia
Fix saisdkdump profile file flag.
d6390a2 
It was not parsing the kv pairs out of the file.

This code is mostly copied from saidiscovery, and put into a separate
file in a class for interfacing with unit tests.

Signed-off-by: Judson Wilson <judsonw@nvidia.com>
@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@judsonwilson-nvidia judsonwilson-nvidia mentioned this pull request Jul 15, 2026
Open
12 tasks
vivekrnv
vivekrnv previously approved these changes Jul 15, 2026
View reviewed changes
@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@judsonwilson-nvidia
Fix missing SWSS_LOG_ENTER()
3b90ef3 
Signed-off-by: Judson Wilson <judsonw@nvidia.com>
@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@judsonwilson-nvidia
Add SWSS_LOG_ENTER() to unit tests.
765b654 
Signed-off-by: Judson Wilson <judsonw@nvidia.com>
@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@judsonwilson-nvidia
Add missing include for swss/logger.h
7363cb5 
Signed-off-by: Judson Wilson <judsonw@nvidia.com>
@mssonicbld

mssonicbld commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Jul 15, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

2 similar comments
@mssonicbld

mssonicbld commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

11 similar comments
@mssonicbld

mssonicbld commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

mssonicbld commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-sairedis-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vivekrnv vivekrnv vivekrnv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@judsonwilson-nvidia @mssonicbld @vivekrnv