Revert temp counter workaround superseded by official fix#1975
Closed
StormLiangMS wants to merge 1 commit into
Closed
Revert temp counter workaround superseded by official fix#1975StormLiangMS wants to merge 1 commit into
StormLiangMS wants to merge 1 commit into
Conversation
The temporary workaround from PR sonic-net#1962 is superseded by the official fix in PR sonic-net#1774.\n\nA direct revert is a no-op on current master because PR sonic-net#1774 already removed the workaround behavior while adding the smart counter polling implementation.\n\nThis empty commit records that the workaround has been intentionally retired.\n\nRefs: https://github.com/sonic-net/sonic-sairedis/pull/1774\nRefs: sonic-net#1962 Signed-off-by: Storm Liang <stormliang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@justin-wong-ce could you please review/confirm this no-op revert record? The temp workaround from #1962 appears already removed by the official fix in #1774 on current master. |
Contributor
Yes this is a no-op revert because the revert is already done in #1774 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporary workaround from #1962 is superseded by the official fix in #1774.
A direct revert of #1962 is a no-op on current
masterbecause #1774 already removed the workaround behavior while adding the smart counter polling implementation. This PR records that the workaround has been intentionally retired and asks the original author to confirm.Note: GitHub did not allow
justin-wong-ceto be requested as a formal reviewer from this PR, so he was tagged in a PR comment instead.