[action] [PR:1962] Cast workaround for N/A counter values from 202412#1967
Closed
mssonicbld wants to merge 1 commit into
Closed
[action] [PR:1962] Cast workaround for N/A counter values from 202412#1967mssonicbld wants to merge 1 commit into
mssonicbld wants to merge 1 commit into
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Casting workaround for N/A counters on management ports on Broadcom platforms. This impacts all hwsku-topo combos that uses management ports (including TH5). Casting from: Azure/sonic-sairedis.msft#69 Proper fix under review at: master: sonic-net#1774 202511: sonic-net#1862 202605: sonic-net#1956 Fixes sonic-net#1753 (temporary fix) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] New feature - [ ] Refactor / cleanup - [ ] Documentation update - [ ] Test improvement ### Approach #### What is the motivation for this PR? To fix `N/A` counters on management ports on Broadcom platforms. ##### Work item tracking - Microsoft ADO **(number only)**: #### How did you do it? Temporarily fill in `0` values for counters that are supported in the usual interfaces but not supported in the management ports. #### How did you verify/test it? `show interface counters` no longer show `N/A` counters. #### Any platform specific information? Broadcom only. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: #1962 |
5 tasks
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Casting workaround for N/A counters on management ports on Broadcom platforms. This impacts all hwsku-topo combos that uses management ports (including TH5).
Casting from:
Azure/sonic-sairedis.msft#69
Proper fix under review at:
master: #1774
202511: #1862
202605: #1956
Fixes #1753 (temporary fix)
Type of change
Approach
What is the motivation for this PR?
To fix
N/Acounters on management ports on Broadcom platforms.Work item tracking
How did you do it?
Temporarily fill in
0values for counters that are supported in the usual interfaces but not supported in the management ports.How did you verify/test it?
show interface countersno longer showN/Acounters.Any platform specific information?
Broadcom only.
Documentation
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com