[sonic_xcvr] Restore Abort advertisement in FW mgmt features#722
Merged
Conversation
Signed-off-by: Pavan Kalyan Nakka <pnakka@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
pnakka28
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the “Abort CMD102h supported” advertisement in the CMIS CDB firmware-management features info text returned by the public transceiver API, after a prior refactor moved feature collection into CdbFwHandler.get_fw_mgmt_features().
Changes:
- Decode and propagate the “abort supported” bit from the firmware management advertisement field through
CdbFwHandler.get_fw_mgmt_features(). - Re-add
Abort CMD102h supported <bool>to theget_module_fw_mgmt_feature()returnedinfotext. - Update unit tests to reflect the updated
get_fw_mgmt_features()tuple shape.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/sonic_xcvr/test_cmis.py | Updates mocked firmware-feature tuples to include abort support bit. |
| tests/sonic_xcvr/test_cdb_fw.py | Updates expected get_fw_mgmt_features() return tuple to include abort support. |
| sonic_platform_base/sonic_xcvr/mem_maps/public/cmis/pages/page9f_cdb.py | Ensures firmware-mgmt advertisement field decodes into per-bit values (bitdecode=True). |
| sonic_platform_base/sonic_xcvr/cdb/cdb_fw.py | Captures abort support bit and returns it via get_fw_mgmt_features(). |
| sonic_platform_base/sonic_xcvr/api/public/cdb_fw.py | Restores abort support advertisement line in returned info text. |
| mgmt_features_adv = reply.get(cdb_consts.CDB_FIRMWARE_MGMT_ADV, {}) | ||
| self.start_payload_size = reply[cdb_consts.CDB_START_CMD_PAYLOAD_SIZE] | ||
| self.is_lpl_only = reply[cdb_consts.CDB_WRITE_MECHANISM] == "LPL" | ||
| self.rw_length_ext = reply[cdb_consts.CDB_READ_WRITE_LENGTH_EXT] + 8 |
prgeor
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the "Abort CMD102h supported" advertisement in the CDB firmware management features return text.
When
get_module_fw_mgmt_feature()was refactored to route all firmware-management features throughCdbFwHandler.get_fw_mgmt_features(). This dropped theAbort CMD102h supportedline that the previous implementation emitted, and the abort advertisement was not captured in return text.Changes:
cdb/cdb_fw.py: captureis_abort_supportedfrom the reply and include it inget_fw_mgmt_features().Abort CMD102h supported <bool>in theinfotext.test_cdb_fw.pyandtest_cmis.pybased on the changes.Motivation and Context
How Has This Been Tested?
test_cdb_fw.pyandtest_cmis.pypassed.get_module_fw_mgmt_feature()API now reportsAbort CMD102h supported <bool>.Additional Information (Optional)