Skip to content

[SmartSwitch HA] Correct ha skip file paths and move them to the ha section#26292

Open
congh-nvidia wants to merge 1 commit into
sonic-net:masterfrom
congh-nvidia:ha
Open

[SmartSwitch HA] Correct ha skip file paths and move them to the ha section#26292
congh-nvidia wants to merge 1 commit into
sonic-net:masterfrom
congh-nvidia:ha

Conversation

@congh-nvidia

Copy link
Copy Markdown
Contributor

Description of PR

Summary:

  1. Some of the recently added skip conditions for the smartswitch HA tests are not in the correct section, move them to the correct section.
  2. Remove the "tests/" prefix, this is wrong actually and would not work in the past, but a recent PR relaxed it: [conditional_mark] Fix nodeid normalization so skips apply when rootdir floats above tests/ #25930. Even though, we still need remove it to align with other entries and pass the alphabetic order check.
  3. Add Mellanox-SN4280-O8C40 to some of the confitions.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202311
  • 202405
  • 202411
  • 202505
  • 202511
  • 202512
  • 202605

Tested branch

  • master
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511
  • 202512
  • 202605
  • N/A

Test result

Tests are correctly skipped on SN4280 HA tetsbed:
image

Approach

What is the motivation for this PR?

Fix issues in the HA test skip conditions.

How did you do it?

  1. Move the entries to the correct section.
  2. Remove the "tests/" prefix.
  3. Add Mellanox-SN4280-O8C40 to some of the confitions.

How did you verify/test it?

Run the full HA test suite on SN4280 HA testbed.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

Remove the tests/ prefix, move them to the correct section and add the Mellanox-SN4280-O8C40 sku
to the conditions.

Signed-off-by: Cong Hou <congh@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown

@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into master. Please review.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@congh-nvidia

Copy link
Copy Markdown
Contributor Author

Hi @nhe-NV @zjswhhh could you please review?

@nhe-NV

nhe-NV commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

/azpw run

@mssonicbld

Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld

Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) stages in build 1167653:

✅Stage Test:

  • Job impacted-area-kvmtest-multi-asic-t1 by Elastictest: retried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants