Wait for bgp in config reload operation for suppress fib test

[echuawu]

Description of PR

Wait for bgp in config reload operation in suppress fib test
It would avoid bgp failed to establish after stopping orchagent

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• New Test case
  • Skipped for non-supported platforms
• Test case improvement

Back port request

• 202311
• 202405
• 202411
• 202505
• 202511
• 202512
• 202605

Approach

What is the motivation for this PR?

BGP sessions failed to establish after stopping orchagent, and it could persist for long time.

How did you do it?

Wait for bgp in config reload operation in suppress fib test

How did you verify/test it?

Run it locally

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[StormLiangMS]

hi @deepak-singhal0408 would you help to take a look? Could this one fix the flaky issue for fib suppress?

[StormLiangMS]

hi @echuawu JFYI, Deepak has a PR to skip this test in 202605 and before, community is working on a refactor of suppress fib. Not sure do we still need to cherrypick this fix to 202511/202605?

[echuawu]

hi @echuawu JFYI, Deepak has a PR to skip this test in 202605 and before, community is working on a refactor of suppress fib. Not sure do we still need to cherrypick this fix to 202511/202605?

It should be cherrypick to 202511.
For the skip in 202605, what's the skip reason? Is it would be skipped accros the full lifecycle of 202605?

[deepak-singhal0408]

hi @deepak-singhal0408 would you help to take a look? Could this one fix the flaky issue for fib suppress?
@StormLiangMS , checked this PR. This is an orthogonal fix. It doesnt address the dynamic toggle offload/propagation race condition that we have been hitting. This addresses BGP session re-establishment flakiness across config reload.

For the skip in 202605, what's the skip reason? Is it would be skipped accros the full lifecycle of 202605?
@echuawu Please refer this issue: #26175
There is an ongoing effort in community to make this command static. Has been discussed in routing-wg and concluded on this approach. We dont see a need for runtime toggle (where in flight routes will compete with this config knob toggle in fpmsyncd, and will have racy behavior).

Is it would be skipped accros the full lifecycle of 202605?
Yes, thats the plan, unless we take this PR set (sonic-net/sonic-swss#4333 and related) in 202605. This is upto release managers to decide. But if it doesnt get picked up, this module will stay skipped for the full lifecycle of 202605.