[action] [PR:21649] Fix telemetry/test_events.py for v6 topos#22928
Merged
Conversation
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
requested review from
guangyao6,
wangxin,
wsycqyz,
xwjiang-ms,
yejianquan and
zbud-msft
as code owners
March 13, 2026 00:06
7 tasks
Collaborator
Author
|
Original PR: #21649 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix the following telemetry events for v6 topos:
sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup.
sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle()
dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo
Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future
Fixes #21648
Type of change
Back port request
Approach
What is the motivation for this PR?
telemetry/test_events.py failed on v6 topos in the following cases:
bgp_events.py
dhcp-relay_events.py
How did you do it?
Add proper v6 fix and skip.
How did you verify/test it?
The test passed on v6 topos.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation