Skip to content

[gnoi_shutdown_daemon] Log gNOI Reboot failure details#404

Merged
vvolam merged 1 commit into
sonic-net:masterfrom
chartsai-nvidia:chartsai/gnoi-shutdown-daemon-err
Jul 17, 2026
Merged

[gnoi_shutdown_daemon] Log gNOI Reboot failure details#404
vvolam merged 1 commit into
sonic-net:masterfrom
chartsai-nvidia:chartsai/gnoi-shutdown-daemon-err

Conversation

@chartsai-nvidia

Copy link
Copy Markdown
Contributor

Why I did it

When the gNOI Reboot (HALT) call to a DPU failed during graceful shutdown, the daemon only logged
"Reboot command failed" and hid stderr. That made failures hard to debug.

Work item tracking
  • Microsoft ADO (number only): N/A

How I did it

  • Stopped hiding stderr on the gNOI Reboot call.
  • Added the return code, target IP:port, and the real error text to the log message.

How to verify it

  • Run a graceful shutdown where the gNOI Reboot call fails (for example, an unreachable DPU).
  • Check syslog and confirm the log now shows rc, target IP:port, and the gNOI error text.

Description for the changelog

Log full gNOI Reboot failure details (rc, target, stderr) in gnoi_shutdown_daemon.

Signed-off-by: Charles Tsai <chartsai@nvidia.com>
@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gpunathilell
gpunathilell self-requested a review July 1, 2026 18:37
@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

13 similar comments
@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@rameshraghupathy

Copy link
Copy Markdown
Contributor

@chartsai-nvidia Please enhance test_send_reboot_command_failure to verify the behavior introduced by this PR. Besides this it LGTM.

@mssonicbld

Copy link
Copy Markdown

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

@vvolam
vvolam requested review from hdwhdw and kishanps July 17, 2026 17:45

@hdwhdw hdwhdw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But beware of our work in sonic-net/sonic-buildimage#28341. When this is merged we should migrate the entire framework to using python native gnoi client, so you won't have this problem.

@vvolam vvolam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvolam
vvolam merged commit a0d435c into sonic-net:master Jul 17, 2026
6 checks passed
@rookie-who

Copy link
Copy Markdown

This PR has the "Request for 202605 Branch" label but is missing 202605-specific test results. Please:

  1. Tick the 202605 checkbox in the "Tested branch" section of the PR description
  2. Provide 202605 branch test evidence in the "Test result" section
  3. Add the label "Tested for 202605 branch" once done

Master branch test results alone are not sufficient for 202605 cherry-pick approval.

Comment on behalf of @vaibhavhd
Review by @vaibhavhd via automated tooling

@mssonicbld

Copy link
Copy Markdown

This PR has backport request label(s) for branch(es): 202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202605: <test result>) in the Test result section as well in your PR description.

---Powered by SONiC BuildBot

@vaibhavhd

Copy link
Copy Markdown
Contributor

202605 tests still not updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants