Issue #22362: Call ConfigReload on full config gnmi update#377
Closed
anders-nexthop wants to merge 1 commit into
Closed
Issue #22362: Call ConfigReload on full config gnmi update#377anders-nexthop wants to merge 1 commit into
anders-nexthop wants to merge 1 commit into
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The full config update handler already saves the config to a file and does yang validation on it. The previous implementation relied on the Reboot command to trigger a ConfigReload, but that command has been implemented on the system level and no longer performs a reload, leaving this operation non-functional. However, we can call ConfigReload directly from the handler and bypass the Reboot, restoring this operation. Modify unit tests to expect test D-Bus calls.
anders-nexthop
force-pushed
the
gnmi-config-reload
branch
from
April 17, 2025 21:59
15cabe7 to
1da25f5
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
marked this pull request as ready for review
April 17, 2025 22:00
anders-nexthop
marked this pull request as draft
April 17, 2025 22:10
6 tasks
Contributor
|
Closing as stale — no activity in over 6 months. Please reopen if you'd still like to pursue this. Thanks for the contribution! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The full config update handler already saves the config to a file and does yang validation on it. The previous implementation relied on the Reboot command to trigger a ConfigReload, but that command has been implemented on the system level and no longer performs a reload, leaving this operation non-functional.
How I did it
Call ConfigReload directly from the handler and bypass the Reboot, restoring this operation.
How to verify it
Unit tests pass successfully.
TBD:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Call ConfigReload on full config gnmi update
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)