[Nokia] [BCM] Set sai_fec_stats_cumulative to accumulate fabric port …#28483
[Nokia] [BCM] Set sai_fec_stats_cumulative to accumulate fabric port …#28483saksarav-nokia wants to merge 1 commit into
Conversation
…counters for DNX platforms Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
@vmittal-msft , please review |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@arista-nwolfe @ysmanman @kenneth-arista do we need this for Arista plaforms ? |
|
@saksarav-nokia , shouldn't this be gated till we have fix in SAI available for J2C+/Ramon chips ? |
@vmittal-msft , Not really. Even if the soc variable is set, it will be NOP till SAI is updated to have the fix. So it is not gated |
|
Created Azure/sonic-buildimage-msft#2713 for msft-2601 |
|
This PR has backport request label(s) for branch(es): msft-202601, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202601: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
|
Hi @vmittal-msft , BCM has marked CS00012471630 & CS00012471630 as RFE. Actually, they need add the same fix (pushed for CS00012468570) to Ramon Code and it is only few line changes. I made the fix in our SAI baseline and tested already and added that code also to csp. So, Could you please ask them to prioritize. |
Yes, this is needed for Arista fabric/line cards as well given that we want DNX chassis systems to behave the same. Tagging @jfeng-arista |
kenneth-arista
left a comment
kenneth-arista
left a comment
There was a problem hiding this comment.
This change looks okay to me. Sakthi, do you want to expand the change to include Arista line and fabric cards?
| sai_disable_srcmacqedstmac_ctrl=1 | ||
| sai_instru_stat_accum_enable=1 | ||
| sai_ecmp_group_members_increment=8 | ||
| sai_fec_stats_cumulative=1 |
There was a problem hiding this comment.
SAI 14.1 and 15.2 already has this fix for J2C+
|
@kenneth-arista similar changes needed for Arista Platforms. |
5 participants
… for DNX platforms
Why I did it
The fabric counters are accumulated as reported in issue #23806
Work item tracking
How I did it
BCM committed the fix for #23806 to SAI 14.1 and SAI 15.2 and also need to enable sai_fec_stats_cumulative=1 soc variable
How to verify it
Verified in Nokia DNX platforms that the fabric counters are accumulated with BCM fix and sai_fec_stats_cumulative=1
Which release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)