Update the script to save a portable docker image#39
Merged
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Sreemoolanathan Iyer <sbiyer@google.com>
|
/azp run |
sreeiyer-1
marked this pull request as ready for review
July 6, 2026 13:32
|
No pipelines are associated with this pull request. |
sonikajindal
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the build ends by generating sonic-alpinevs.img.gz. The user has to run the build_container.sh script to bundle the alpine docker and the VM, which is part of the sonic-alpine and not part of the image. This is not a problem in the dev environment, but when someone uses the sonic-alpinevs.img.gz from the official build, they are forced to clone sonic-alpine to build the image.
The new build_alpinevs_docker_save.sh script takes sonic-alpinevs.img.gz and saves the docker image along with the VM, so that a user can load it directly. The old build_alpinevs_container.sh now wraps a docker load so that the existing users of the script can do exactly what they were doing earlier.
An after-build hook will be added to slave.mk which will call the build_alpinevs_docker_save.sh via the kvm_image.mk
Unit tested by running the arbitration test,