Add xcvrd configuration resolution HLD#2362
Open
aditya-nexthop wants to merge 1 commit into
Open
Conversation
Add the High Level Design describing how xcvrd resolves its runtime tunables via a single XcvrdConfig object that reads the xcvrd section of pmon_daemon_control.json directly, replacing the per-tunable command-line-flag mechanism. Adding a new tunable becomes a one-field change to XcvrdConfig, and changing a flag at runtime only requires restarting xcvrd rather than having pmon regenerate the whole supervisord template. Link the new HLD from sonic_docs_toc.md under the xrcvd section. Signed-off-by: aditya-nexthop <aditya@nexthop.ai>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Author
moshemos
approved these changes
Jul 14, 2026
Contributor
|
Hi @aditya-nexthop , it is a good idea to simplify the flow of adding parameters to xcvrd. Based on your proposal, I think we could do it more generic. How about changing XcvrdConfig to PmonDaemonConfig? Other daemons like thermalctld, psud could also be beneficial from this new desing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the High Level Design describing how xcvrd resolves its runtime tunables via a single XcvrdConfig object that reads the xcvrd section of pmon_daemon_control.json directly, replacing the per-tunable command-line-flag mechanism. Adding a new tunable becomes a one-field change to XcvrdConfig, and changing a flag at runtime only requires restarting xcvrd rather than having pmon regenerate the whole supervisord template.
Link the new HLD from sonic_docs_toc.md under the xrcvd section.
Associated code PRs to be merged in order:
sonic-net/sonic-platform-daemons#854
sonic-net/sonic-buildimage#28306