Add routed port support to dhcp_relay#2276
Open
devesh-nexthop wants to merge 5 commits into
Open
Conversation
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
devesh-nexthop
force-pushed
the
dhcp_relay_routed_ports
branch
from
April 2, 2026 00:44
dce99b6 to
0131de2
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
devesh-nexthop
force-pushed
the
dhcp_relay_routed_ports
branch
from
April 2, 2026 01:18
0131de2 to
f0e7e4e
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
devesh-nexthop
marked this pull request as ready for review
April 2, 2026 01:18
|
@devesh-nexthop can we get some reviewers tagged here who have been involved in the discussion |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
There was a problem hiding this comment.
My Understanding is
- PORT | EthernetX contains dhcp_servers/dhcpv6_servers .
- INTERFACE|EthernetX| makes EthernetX a routed L3 Interface
- A Plain L2 PORT Without IP should not be treated as valid DHCP relay Interface.
Can we document whether this invalid case is rejected by config/YANG validation, ignored by dhcp_relay, or logged as an error?
| - [5.1.3 Interop with Port-Based DHCP Server](#513-interop-with-port-based-dhcp-server) | ||
| - [5.1.4 DHCP Monitor](#514-dhcp-monitor) | ||
| - [5.1.5 Dual-Tor Support](#515-dual-tor-support) | ||
| - [5.1.6 Routed Port Support](#516-physical-port-support) |
Collaborator
There was a problem hiding this comment.
Like we discussed in the meeting, please clarify whether the same support is available for port-channel interfaces and routed VLAN subinterfaces as well. If it is not supported, it would be better to explicitly document this limitation and explain why the same support cannot be provided.
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
…-net#2072) NO-ISS: MACsec gearbox: Deterministic MACsec backend selection for gearbox ports Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
devesh-nexthop
force-pushed
the
dhcp_relay_routed_ports
branch
from
June 16, 2026 18:55
3b6893c to
5797254
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
| "dhcpv4_servers": ["10.0.0.1", "10.0.0.2"], | ||
| "circuit_id_format": "custom", | ||
| "circuit_id": "CustomCircuitID", | ||
| "max_hop_count": "10" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes PR:
[sonic-dhcp-relay] sonic-net/sonic-dhcp-relay#102
[sonic-buildimage] sonic-net/sonic-buildimage#26897
[sonic-mgmt] sonic-net/sonic-mgmt#24117