Added suffix handling for Qt SAVE file dialogs#1727
Open
wolfpackmars2 wants to merge 1 commit into
Open
Conversation
Member
|
@wolfpackmars2 This looks much better than the last attempt. Simple and localized to the one file! Unfortunately my Linux box is still broken so I'll have to let someone else test this. I might just trust that you tested it enough since it's so simple and restricted to QT ;-) @WickedSmoke can you give it a look, if not an actual build/test? |
WickedSmoke
reviewed
Jun 25, 2026
| public: | ||
| QFileDialog fileDialogQ; | ||
| QStringList filters; | ||
| QStringList defaultSuffixes; |
Contributor
There was a problem hiding this comment.
There's no need to add new data members. I edited this patch to remove them on my qt-ext3 branch.
WickedSmoke
reviewed
Jun 25, 2026
|
|
||
| // NOTE: The file extension is automatically set by the KDE native | ||
| // dialog but not with the Qt one. | ||
| // dialog and now with the Qt one. |
Contributor
There was a problem hiding this comment.
This is a comment on the behavior of the platform dialogs, not about this class. I've updated the comment to include Gtk on my qt-ext3 change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1689
Not much else to say, the code is straightforward and matches how guigtk.cpp handles file extensions as closely as possible.
This also fix how file extensions are handled for other export file types, like .stl etc.
I have functionally tested this in Ubuntu 24.04.