Feat: Display Tag in Commit Details#20
Conversation
SatheeshvarmaSJ
left a comment
SatheeshvarmaSJ
left a comment
There was a problem hiding this comment.
Just a test to see if the review is working.
ancy-augustin
changed the title
|
@SatheeshvarmaSJ Is this tested, reviewed and ready to merge? |
There was a problem hiding this comment.
Since this is a constant, this VI can be inline.
There was a problem hiding this comment.
Since this is a constant, this VI can be inline.
There was a problem hiding this comment.
As per this comment in the Exit case, the VI title should not have the beta tag added and saved.
Just leave the title as below
Instead of
There was a problem hiding this comment.
The beta tag is removed in Exit case and VI Properties and saved.
But in Initilaize case, the Beta tag is present with a note as below
There was a problem hiding this comment.
The entire tab control seems to be shifted compared to the previous version. This makes the tab titles slightly clip into the title bar. Refer the previous version for the size and position and adjust.
There was a problem hiding this comment.
Adjusted the position.
There was a problem hiding this comment.
Better to not save the dropdowns with the details. Clear them while saving the VI.
There was a problem hiding this comment.
Cleared the drop down contents
There was a problem hiding this comment.
nit: The default visible case is different than Initialize (or a significant case). Better to have the default case to Initialize or any one of the most important/frequently accessed case.
There was a problem hiding this comment.
Initialize case is set to default visible case
There was a problem hiding this comment.
Previously existing new line is missing.
There was a problem hiding this comment.
Reverted to the previously existing format string and inserted the tag details as specified in the prototype
There was a problem hiding this comment.
Build the string using the newly created constant instead of hardcoding.
There was a problem hiding this comment.
Addressed the comment
There was a problem hiding this comment.
major: The Tag always displays the latest tag available in the branch and not specific to the selected commit
This commit should display the tag as Tag: v1.1.0.2
There was a problem hiding this comment.
Modified to display the tag commit specific
I have reviewed and requested changes @KarthikAbiram |
|
Addressed the review comments. Kindly have a look and share your feedback @SatheeshvarmaSJ |
|
@SatheeshvarmaSJ Please let me know if these can be merged |
3 participants
What does this pull request accomplish?
The PR adds functionality to display the tag (if exists) along with Commit Details.
Implementation Details
Implemented by checking the existence of tags. If tags found, the latest tag is retrieved and displayed in the Commit Details.
Files Changed
Code Compare Tool For Git.viWhy should this pull request be merged?
Merging this PR allows the user to get the tag details (if exists) thus improving user experience.
Checklist: