Skip to content

Fix SolidusPromotion OrderRecalculator patch#6480

Open
sofiabesenski4 wants to merge 1 commit into
solidusio:mainfrom
SuperGoodSoft:sofia/fix-imou-bug-preventing-use-with-soliduspromotions
Open

Fix SolidusPromotion OrderRecalculator patch#6480
sofiabesenski4 wants to merge 1 commit into
solidusio:mainfrom
SuperGoodSoft:sofia/fix-imou-bug-preventing-use-with-soliduspromotions

Conversation

@sofiabesenski4
Copy link
Copy Markdown
Contributor

Summary

The method signature of the InMemoryOrderUpdater changed to include the persist flag. This would previously raise an ArgumentError after configuring the app to use the InMemoryOrderUpdater, and passing an explicit argument for persist.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions Bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label May 12, 2026
@sofiabesenski4 sofiabesenski4 marked this pull request as ready for review May 12, 2026 21:11
@sofiabesenski4 sofiabesenski4 requested a review from a team as a code owner May 12, 2026 21:11
The method signature of the InMemoryOrderUpdater changed to include the
`persist` flag. This would previously raise an ArgumentError after
configuring the app to use the InMemoryOrderUpdater, and passing an
explicit argument for persist.

Co-authored-by: Adam Mueller <adam@super.gd>
@sofiabesenski4 sofiabesenski4 force-pushed the sofia/fix-imou-bug-preventing-use-with-soliduspromotions branch from a2309c4 to 4feb6ec Compare May 12, 2026 21:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (a0746e6) to head (4feb6ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6480   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         991      992    +1     
  Lines       20832    20838    +6     
=======================================
+ Hits        18683    18689    +6     
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added the type:bug Error, flaw or fault label May 13, 2026
@tvdeyen tvdeyen added the backport-v4.7 Backport this pull-request to v4.7 label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.7 Backport this pull-request to v4.7 changelog:solidus_promotions Changes to the solidus_promotions gem type:bug Error, flaw or fault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants