Fix SolidusPromotion OrderRecalculator patch#6480
Open
sofiabesenski4 wants to merge 1 commit into
Open
Conversation
The method signature of the InMemoryOrderUpdater changed to include the `persist` flag. This would previously raise an ArgumentError after configuring the app to use the InMemoryOrderUpdater, and passing an explicit argument for persist. Co-authored-by: Adam Mueller <adam@super.gd>
a2309c4 to
4feb6ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6480 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 991 992 +1
Lines 20832 20838 +6
=======================================
+ Hits 18683 18689 +6
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarednorman
approved these changes
May 12, 2026
tvdeyen
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The method signature of the InMemoryOrderUpdater changed to include the
persistflag. This would previously raise an ArgumentError after configuring the app to use the InMemoryOrderUpdater, and passing an explicit argument for persist.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: