Skip to content

fix: stage badge for specific primitive#768

Closed
jaysencpp wants to merge 1 commit into
solidjs-community:mainfrom
jaysencpp:main
Closed

fix: stage badge for specific primitive#768
jaysencpp wants to merge 1 commit into
solidjs-community:mainfrom
jaysencpp:main

Conversation

@jaysencpp

Copy link
Copy Markdown

The stage badge is not displaying correctly.

Relevant issue: #757

This was already fixed for the badges shown on the front page (#759), however it's not fixed for a specific primitive's page.

To reproduce error:

@changeset-bot

changeset-bot Bot commented Mar 2, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ade1d87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@atk

atk commented Mar 2, 2025

Copy link
Copy Markdown
Member

The fix is already on main, we just need to roll it out.

@jaysencpp

Copy link
Copy Markdown
Author

The fix is already on main, we just need to roll it out.

Oh, that's great. Though I'm not quite sure what you mean by that since what I'm seeing on the main branch is wrong: https://github.com/solidjs-community/solid-primitives/blob/main/site/src/routes/package/%5Bname%5D/(package).tsx#L43

@aquaductape

Copy link
Copy Markdown
Member

Sorry @jaysencpp, I didn't realize you made the correct fix, I went ahead and pushed a fix #793 and the live site shows the correct stage badge now.

Thank you so much for taking the time to fix this, had I seen your PR first, I would have merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants