Fixing rotations - #6
Open
Dearex wants to merge 1 commit into
Open
Conversation
as hex._rotate_clockwise doesnt change the hex but returns a value, the rotation was only ever done once. the step-calculation yielded wrong steps for counterclockwise rotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rotations were only done once as (hex._rotate_clockwise() for _ in range(steps)) yields the same value over and over again, as hex doesn't change.
The step calculation yields the number of clockwise steps for negative angles, so I removed the distinction (otherwise abs the angle before mod).
Todo: Extend test file. The test didn't catch the issue as it only tests 0° and 60° rotation. Also the use of sets in the testfile allows for a simple change of the angles to also pass the test, as the opposing 120° hex rotations are the same set as 60° rotation. Thus I changed the return type to tuple