Skip to content

improvement: migrated from constructor injection#765

Open
pilat-martin wants to merge 7 commits into
mainfrom
improvement/migrate-constructor-injection
Open

improvement: migrated from constructor injection#765
pilat-martin wants to merge 7 commits into
mainfrom
improvement/migrate-constructor-injection

Conversation

@pilat-martin
Copy link
Copy Markdown
Contributor

@pilat-martin pilat-martin commented Jul 2, 2025

Frontend Pull Request Description

POC of migration from constructor injection. Charts and Dashboards will also need to be updated with changes done in bits.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have updated change log
  • I have been following Definition of done
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new lint warnings
  • New and existing unit tests pass locally and on CI with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context (if necessary)

@pavlo-poimanov pavlo-poimanov force-pushed the improvement/migrate-constructor-injection branch from 13921b8 to 4b5a406 Compare February 25, 2026 10:19
@pavlo-poimanov pavlo-poimanov self-assigned this Feb 25, 2026
@pavlo-poimanov pavlo-poimanov marked this pull request as ready for review February 25, 2026 10:22
@pavlo-poimanov pavlo-poimanov force-pushed the improvement/migrate-constructor-injection branch from 4b5a406 to 1f9dbfe Compare May 4, 2026 11:09
pavlo-poimanov and others added 6 commits May 4, 2026 14:39
…ection

Co-authored-by: Copilot <copilot@github.com>
…mponents and services

- Updated various components and services to utilize Angular's `inject` function for dependency injection, improving code readability and maintainability.
- Refactored test setups to use `TestBed` for injecting dependencies, reducing boilerplate code and enhancing test clarity.
- Removed unnecessary constructor parameters and simplified service instantiation in tests.
- Ensured consistent usage of `PIZZAGNA_EVENT_BUS` across services and components for event handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants