fix(harness): enforce real verifier gates

[EfeDurmaz16]

Summary

• split shared CI and harness defenses from fix(x402): harden cross-SDK verifier and CI gates #226 into a harness-owned PR
• require declared modes to call real SDK verifiers and add managed-signer drain vectors
• strengthen test, vector, matrix, boot-policy, and payment-channels revision accounting

Verification

• TypeScript MPP build and harness typecheck pass
• standalone meta-gates run on this branch
• full cross-SDK conformance is intentionally merge-order dependent on the sibling language PRs targeting ci(harness): radar layers + anti-false-green gates + cross-SDK protocol conformance #219

Stack

Targets #219 as requested. This PR should merge after the language fixes it exercises, or together with them, so the blocking gates never encode unavailable behavior.

[EfeDurmaz16]

@greptile-apps please review

[greptile-apps]

Greptile Summary

This PR hardens the conformance harness by requiring runners that declare a verifier mode to actually execute it, and by extending the managed-signer transfer guard to cover multisig signer tails and Token-2022 ATA derivation. It also replaces several inline CI scripts with testable modules and tightens a number of accounting gates.

• Declared-mode enforcement (mode-support.ts, conformance.test.ts): a runner that lists a mode in modesByIntent can no longer silently return unsupported-mode; strictModesByIntent additionally requires at least one accept and one reject vector per declared verifier mode.
• assertNoManagedTransferFunding extraction (x402.ts): the inline authority+source check is promoted to an exported, testable function that also covers multisig signer positions and Token-2022 ATAs; three new unit tests pin each rejection path.
• Infrastructure tightening: verify-routed-sdk-gate.mjs replaces 40 lines of inline CI JavaScript with a tested module; vector accounting migrates from directory-level to per-file FILE_CONSUMERS; Semgrep is pinned to a Docker SHA and flipped from advisory to blocking.

Confidence Score: 5/5

Safe to merge; the logic changes are well-tested and fail-closed, with only minor diagnostic-quality issues in a new shell script and a gate error message.

Every new enforcement path has a corresponding unit or integration test. The assertNoManagedTransferFunding refactoring is semantically equivalent for the single-authority case and strictly stronger for multisig tails. The two observations — a shared error message in verify-routed-sdk-gate.mjs and a whitespace-sensitive grep in check-payment-channels-revision.sh — affect diagnostic clarity only and do not change whether the gate fires or passes.

scripts/verify-routed-sdk-gate.mjs (error message ambiguity between the two mutual-exclusion failure modes) and scripts/check-payment-channels-revision.sh (4-space-hardcoded indent on the action.yml SHA check).

Important Files Changed

Filename	Overview
harness/src/conformance/mode-support.ts	New module enforcing declared mode coverage; assertDeclaredModeWasExecuted and assertStrictModeCoverage close the false-green gap for runners that skip verifier vectors.
harness/src/conformance/x402.ts	Refactors inline managed-signer drain check into exported assertNoManagedTransferFunding; now covers multisig signer tails (positions 3+) and Token-2022 ATA derivation alongside direct source and authority.
harness/src/conformance/runners.ts	Adds modesByIntent/strictModesByIntent to runner manifests with robust validation: known intents, allowed mode sets, non-empty arrays, no duplicates, and strict modes must subset declared modes.
scripts/verify-routed-sdk-gate.mjs	Extracts inline CI gate logic into a testable module; introduces docs_only mutual-exclusion check but the shared error message covers two distinct failure modes, making diagnosis harder.
harness/test/conformance.test.ts	Integrates mode-support enforcement into the per-language conformance loop; assertDeclaredModeWasExecuted fires per-vector and assertStrictModeCoverage fires in afterAll for a two-layer gate.
harness/test/vector-accounting.test.ts	Migrates directory-level consumer map to per-file FILE_CONSUMERS and adds a stale-entry check; a new file beside an existing consumed vector now fails closed instead of inheriting its directory's coverage claim.
harness/test/ci-coverage-gate.test.ts	Replaces regex text-scan with a proper YAML-parse + vitest-command extraction; only test/ paths explicitly passed to vitest run within a harness working-directory count as wired. Structured CI_EXEMPT entries now require owner/date/removalCondition.
.github/workflows/semgrep.yml	Pins Semgrep to a Docker image SHA, removes pip install, and flips the source scan from advisory (continue-on-error) to blocking; scan step now passes SEMGREP_ERROR_ON_FINDINGS=1.
scripts/check-payment-channels-revision.sh	New script asserting all workflows pin the same payment-channels SHA; the action.yml check uses grep -Fqx with a hardcoded 4-space indent, making it fragile to indentation changes.
scripts/select-pr-workflows.mjs	Refactors path matching from flat prefix arrays to {directories, files} structure; any change under SHARED_HARNESS_PATHS now triggers all SDK workflows (previously only the harness job). Adds docs_only output for the gate.
harness/test/x402-exact-managed-signer.test.ts	New test covering three rejection paths for managed-signer drain: multisig signer tail, direct source match, and Token-2022 ATA derivation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Runner manifest JSON] -->|isRunnerManifest| B{Has modesByIntent?}
    B -->|No| C[Default: unsupported-mode allowed for all modes]
    B -->|Yes| D[isModeCapabilities validation\n- known intents only\n- non-empty arrays\n- no duplicates]
    D -->|Has strictModesByIntent?| E[strictModesByIntent must subset modesByIntent\n- only verifier modes allowed]
    D -->|No| F[Mode declared: unsupported-mode is a conformance error]
    E --> F
    F --> G[Per-vector: assertDeclaredModeWasExecuted]
    G -->|unsupported-mode returned| H[Test FAILS immediately]
    G -->|accept / reject| I[recordModeExecution]
    I --> J[afterAll: assertStrictModeCoverage]
    J -->|strict mode missing accept OR reject| K[Suite FAILS]
    J -->|both outcomes covered| L[Strict mode gate passes]
    C --> M[afterAll: UNSUPPORTED_MODE_EXEMPTIONS check]
    M -->|no exemption and 0 executions| N[Orphaned mode error]
    M -->|exemption present| O[OK]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Runner manifest JSON] -->|isRunnerManifest| B{Has modesByIntent?}
    B -->|No| C[Default: unsupported-mode allowed for all modes]
    B -->|Yes| D[isModeCapabilities validation\n- known intents only\n- non-empty arrays\n- no duplicates]
    D -->|Has strictModesByIntent?| E[strictModesByIntent must subset modesByIntent\n- only verifier modes allowed]
    D -->|No| F[Mode declared: unsupported-mode is a conformance error]
    E --> F
    F --> G[Per-vector: assertDeclaredModeWasExecuted]
    G -->|unsupported-mode returned| H[Test FAILS immediately]
    G -->|accept / reject| I[recordModeExecution]
    I --> J[afterAll: assertStrictModeCoverage]
    J -->|strict mode missing accept OR reject| K[Suite FAILS]
    J -->|both outcomes covered| L[Strict mode gate passes]
    C --> M[afterAll: UNSUPPORTED_MODE_EXEMPTIONS check]
    M -->|no exemption and 0 executions| N[Orphaned mode error]
    M -->|exemption present| O[OK]

Loading

_{Reviews (10): Last reviewed commit: "Merge remote-tracking branch 'origin/fix..." | Re-trigger Greptile}

[EfeDurmaz16]

@greptile-apps please re-review. The router now classifies both sides of renames, validates every classifier output, requires selected workflows XOR explicit docs-only, and exercises missing/contradictory/skip cases in a blocking gate test; adversarial Sol review is clean.

[EfeDurmaz16]

@greptile-apps please review

[EfeDurmaz16]

@greptileai review

[EfeDurmaz16]

@greptileai review