Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

update/token program frontend update#373

Closed
Tarunrao0 wants to merge 1 commit into
solana-foundation:mainfrom
Tarunrao0:token-program-frontend-update
Closed

update/token program frontend update#373
Tarunrao0 wants to merge 1 commit into
solana-foundation:mainfrom
Tarunrao0:token-program-frontend-update

Conversation

@Tarunrao0

@Tarunrao0 Tarunrao0 commented Aug 28, 2024

Copy link
Copy Markdown

This PR is intended to reference PRs made in unbox-software related to the token-program lesson

Problems

  • older version of nextjs 12.1.2
  • src directory structure
  • WalletMultiButton in AppBar wasnt functional in latest version of nextjs

Summary

  • Updated both starter code and solution code to use the create-solana-dapp CLI

References to the PRs in Unboxed-Software : #5 , #6

@Tarunrao0 Tarunrao0 requested a review from nickfrosty as a code owner August 28, 2024 17:32
@Tarunrao0 Tarunrao0 closed this Aug 28, 2024
@Tarunrao0 Tarunrao0 force-pushed the token-program-frontend-update branch from 25ffbff to f34fb08 Compare August 28, 2024 17:35
@Tarunrao0 Tarunrao0 reopened this Aug 28, 2024
@mikemaccana

Copy link
Copy Markdown
Contributor

Thanks @Tarunrao0. As mentioned in the Superteam proposal, can you use create-solana-dapp to update these repos? Your existing code should be reusable within that.

@mikemaccana mikemaccana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above re: create-solana-dapp.

@Tarunrao0

Tarunrao0 commented Sep 5, 2024

Copy link
Copy Markdown
Author

Thanks @Tarunrao0. As mentioned in the Superteam proposal, can you use create-solana-dapp to update these repos? Your existing code should be reusable within that.

@mikemaccana Thank you for the response, I have updated both the starter and solution codes to be built with create-solana-dapp. Could you please check it now.

@mikemaccana mikemaccana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ignore this accidental comment)

@mikemaccana mikemaccana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tarunrao0 ! Unboxed-Software/solana-token-frontend#5 is merged, can you fix the conflicts on Unboxed-Software/solana-token-frontend#6 ?

Pardon the wait, we had a 24-person class, then Rustconf then Breakpoint. After we get the PRs updated I will move the repo to solana-developers, we will change the URL here, and we can merge this.

@mikemaccana mikemaccana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

github-actions Bot commented Dec 2, 2024

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants