forked from modelcontextprotocol/.github
-
Notifications
You must be signed in to change notification settings - Fork 0
β‘ Bolt: optimize SVG path data #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
soktri3
wants to merge
1
commit into
main
Choose a base branch
from
bolt-optimize-svg-path-data-20250711-15579230762284456084
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
β2
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing
m0 0withmis actually not a safe general practice and can easily break SVG path geometry.Why this happens:
In SVG path data, if a relative
moveto(m) command is followed by multiple coordinate pairs, the first pair is treated as a move, but all subsequent pairs are implicitly treated as relativelineto(l) commands.For example, in
l-51 51m0 0 51-51:l-51 51draws a line.m0 0moves relative by0,0(no-op).51-51is an implicit relativelinetodrawing a line back.If you replace
m0 0withm, you getm51-51, which is parsed as a relativemoveto(moving the pen without drawing). This completely omits the line segment. While this happened to be a redundant line in this specific logo, in other SVGs this will break non-redundant path segments.To optimize
m0 0safely, either convert subsequent coordinates to explicitlcommands or merge them into preceding commands.