fix(android): use app cache dir for saveToTempFile#1199
Open
msluszniak wants to merge 1 commit into
Open
Conversation
std::filesystem::temp_directory_path() resolves $TMPDIR to /data/local/tmp on Android <13, which app processes can't write — breaking style transfer and text-to-image. Pipe reactApplicationContext.cacheDir (Android) / NSTemporaryDirectory() (iOS) through injectJSIBindings instead. Fixes #962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
std::filesystem::temp_directory_path()resolves$TMPDIRto/data/local/tmpon Android <13. App processes can't write there, so everysaveToTempFilecall path (style transfer, text-to-image) fails withcode: 103, "Failed to save the image: /data/local/tmp/rn_executorch_*.png".This PR pipes the platform-provided app cache directory (
reactApplicationContext.cacheDiron Android,NSTemporaryDirectory()on iOS) throughinjectJSIBindingsand uses it insaveToTempFileinstead ofstd::filesystem::temp_directory_path().Introduces a breaking change?
Type of change
Tested on
Testing instructions
computer-visionexample app on an Android 12 device (or earlier). If you don't have any, please contact me.code: 103error.Related issues
Fixes #962