Skip to content

30 avoid reserved parent and other not prefixed methods of referencable#32

Open
SusieGoebel wants to merge 34 commits into
mainfrom
30-avoid-reserved-parent-and-other-not-prefixed-methods-of-referencable
Open

30 avoid reserved parent and other not prefixed methods of referencable#32
SusieGoebel wants to merge 34 commits into
mainfrom
30-avoid-reserved-parent-and-other-not-prefixed-methods-of-referencable

Conversation

@SusieGoebel
Copy link
Copy Markdown
Member

@SusieGoebel SusieGoebel commented Jun 2, 2026

No description provided.

SusieGoebel added 25 commits May 27, 2026 14:10
@SusieGoebel
Renmae ParentType to
c13a33e
@SusieGoebel
Replace internal $parent with _$, and also accessor parent with $
b0e7a00
@SusieGoebel
change setParent to real setter
e071277
@SusieGoebel
Prefix more methods with $, only toJson() should stay without prefix …
c00ba18 
…and not hidden behind a symbol
@SusieGoebel
Make another private method private, also define not exported symbol …
d773ee8 
…for first one
@SusieGoebel
All private methods are only via private symbols now
f482244
@SusieGoebel
replace assign refs by symbol SERIALIZE_ASSIGN_REFS
6188cbf
@SusieGoebel
Reorganize Referencable methods by purpose, to make more symbolized
ac99b75
@SusieGoebel
New symbols add to Reference and remove from reference
30d0bb7
@SusieGoebel
Remove explicit parent removal, maybe cause of circular on strict mode
52c362c
@SusieGoebel
Rename all referencable symbols to have the class Referencable explic…
8f09bbd 
…it as first part
@SusieGoebel
Deserialization symbols
8914928
@SusieGoebel
desinging an extra internal API instead of symbols to reinstall IDE n…
e7c7743 
…avigation
@SusieGoebel
Inverse triggers moved to public api object to keep IDE working
fbb4d12
@SusieGoebel
More methods just from Internal API of Referencable
5e38ef6
@SusieGoebel
Change API signature to expose Self and Parent as types, to tighten t…
aa16b1d 
…he type bounds. Also include getContainer since it is only used in the API methods
@SusieGoebel
Move construction of refs from context initialization to ref's toJson
09c8c36
@SusieGoebel
Reorganize referencable methods
7d52e21
@SusieGoebel
Reove explicit URI since we have the whole modelMeta currently available
caf0460
@SusieGoebel
Make treechildren private, only expose access on internal API, hence …
d3ae249 
…needing to change some tests that expose containers e.g. for removal - which other methods should handle
@SusieGoebel
Also make otherReferences private; on API as otherLinks, now only use…
b8ba06e 
…d in the single case where the proxy exposes no delete from a relationship option
@SusieGoebel
private symbols for treeCHildren and links, now showing problem on tr…
9a11c4d 
…ee containers with direct usage of push
@SusieGoebel
Precise typing to make sure that Referencable of P is kept as info
3d336d5
@SusieGoebel
Apply same typing to tree interface
3c96937
@SusieGoebel
Use P, not the T[Parent] for all wiring in order to keep the type exp…
a918fc4 
…licit
@SusieGoebel SusieGoebel linked an issue Jun 2, 2026 that may be closed by this pull request
Avoid reserved parent and other not prefixed methods of referencable #30
Open
@SusieGoebel SusieGoebel marked this pull request as ready for review June 3, 2026 08:21
@SusieGoebel SusieGoebel requested a review from Noah1891 June 3, 2026 08:21
Noah1891
Noah1891 reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Noah1891 Noah1891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When checking why we could leave out the delete method in re-tree-list and re-link-list-container.ts I discovered a bug when calling delete with RELAXED mode on a ReLinkListContainer, but this has nothing to do with this pull request though but should be fixed in another issue
  2. Since the goal also was to prevent reserving string names, would __referenceInitializers which is part of the prototype of Referenceable be such a case and could theoretically also be replaced by a symbol?

@SusieGoebel SusieGoebel mentioned this pull request Jun 5, 2026
Open
@SusieGoebel
Copy link
Copy Markdown
Member Author

SusieGoebel commented Jun 5, 2026

  1. When checking why we could leave out the delete method in re-tree-list and re-link-list-container.ts I discovered a bug when calling delete with RELAXED mode on a ReLinkListContainer, but this has nothing to do with this pull request though but should be fixed in another issue
    Yes, issue created - please fill the test to show the bug in there.
  1. Since the goal also was to prevent reserving string names, would __referenceInitializers which is part of the prototype of Referenceable be such a case and could theoretically also be replaced by a symbol?
    Nice catch, I did it in commit dbf708b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noah1891 Noah1891 Noah1891 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Avoid reserved parent and other not prefixed methods of referencable

2 participants

@SusieGoebel @Noah1891