Skip to content

[LinearSolver,LinearSystem] Include appropriate inl to no longer on extern symbols#6119

Merged
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:fixincludes
May 27, 2026
Merged

[LinearSolver,LinearSystem] Include appropriate inl to no longer on extern symbols#6119
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:fixincludes

Conversation

@alxbilger
Copy link
Copy Markdown
Contributor

The changed components relied on extern symbol definition to instantiate them, but they did not have access to all the required definitions.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 21, 2026
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 27, 2026
@fredroy fredroy merged commit 99031d5 into sofa-framework:master May 27, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants