Skip to content

Potential fixes for 2 code quality findings #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjomo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Potential fixes for 2 code quality findings #177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7164635
Apply suggested fix to netty-socketio-core/src/test/java/com/socketio…
sanjomo May 21, 2026
3bc7325
Apply suggested fix to netty-socketio-core/src/test/java/com/socketio…
sanjomo May 21, 2026
1bde065
Refactor SSL tests to use helper methods
sanjomo May 21, 2026
8852525
Merge branch 'main' into ai-findings-autofix/netty-socketio-core-src-…
sanjomo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 36 additions & 88 deletions ...ketio-core/src/test/java/com/socketio4j/socketio/transport/SocketIoJavaClientSslTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,23 @@ public class SocketIoJavaClientSslTest {

private SocketIOServer server;

private X509TrustManager trustAllManager() {
return new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[0];
}
};
}

@AfterEach
public void tearDown() {
if (server != null) {
Expand All @@ -74,20 +91,7 @@ public void shouldReceiveHelloEventAndAckOverWssFromJavaClient() throws Exceptio
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

X509TrustManager trustAll = new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[0];
}
};
X509TrustManager trustAll = trustAllManager();
SSLContext sslContext = SSLContext.getInstance("TLS");
sslContext.init(null, new TrustManager[] { trustAll }, new SecureRandom());

Expand All @@ -97,12 +101,7 @@ public X509Certificate[] getAcceptedIssuers() {
.readTimeout(1, TimeUnit.MINUTES)
.build();

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "websocket" };
opts.webSocketFactory = okHttp;
opts.callFactory = okHttp;
IO.Options opts = createIoOptions(okHttp, "websocket");

Socket socket = IO.socket("https://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -153,20 +152,7 @@ public void shouldHandshakeOverWssWhenSslProtocolNotExplicitlyConfigured() throw
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

X509TrustManager trustAll = new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[0];
}
};
X509TrustManager trustAll = trustAllManager();
SSLContext sslContext = SSLContext.getInstance("TLS");
sslContext.init(null, new TrustManager[] { trustAll }, new SecureRandom());

Expand All @@ -176,12 +162,7 @@ public X509Certificate[] getAcceptedIssuers() {
.readTimeout(1, TimeUnit.MINUTES)
.build();

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "websocket" };
opts.webSocketFactory = okHttp;
opts.callFactory = okHttp;
IO.Options opts = createIoOptions(okHttp, "websocket");

Socket socket = IO.socket("https://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -238,20 +219,7 @@ public void shouldPollUpgradeToWebSocketWithServerPushAndClientHelloAckOverWss()
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

X509TrustManager trustAll = new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[0];
}
};
X509TrustManager trustAll = trustAllManager();
SSLContext sslContext = SSLContext.getInstance("TLS");
sslContext.init(null, new TrustManager[] { trustAll }, new SecureRandom());

Expand All @@ -261,12 +229,7 @@ public X509Certificate[] getAcceptedIssuers() {
.readTimeout(1, TimeUnit.MINUTES)
.build();

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "polling", "websocket" };
opts.webSocketFactory = okHttp;
opts.callFactory = okHttp;
IO.Options opts = createIoOptions(okHttp, "polling","websocket");

Socket socket = IO.socket("https://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -322,10 +285,7 @@ public void shouldReceiveHelloEventAndAckOverPlainWebSocketFromJavaClient() thro
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "websocket" };
IO.Options opts = createIoOptions(null, "websocket");

Socket socket = IO.socket("http://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -376,20 +336,7 @@ public void shouldReceiveHelloEventAndAckOverPollingFromJavaClient() throws Exce
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

X509TrustManager trustAll = new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) {
}

@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) {
}

@Override
public X509Certificate[] getAcceptedIssuers() {
return new X509Certificate[0];
}
};
X509TrustManager trustAll = trustAllManager();
SSLContext sslContext = SSLContext.getInstance("TLS");
sslContext.init(null, new TrustManager[] { trustAll }, new SecureRandom());

Expand All @@ -399,12 +346,7 @@ public X509Certificate[] getAcceptedIssuers() {
.readTimeout(1, TimeUnit.MINUTES)
.build();

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "polling" };
opts.webSocketFactory = okHttp;
opts.callFactory = okHttp;
IO.Options opts = createIoOptions(okHttp, "polling");

Socket socket = IO.socket("https://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -455,10 +397,7 @@ public void shouldReceiveHelloEventAndAckOverPlainPollingFromJavaClient() throws
int port = awaitBoundPort(server);
assertTrue(port > 0, "server did not bind an ephemeral port");

IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = new String[] { "polling" };
IO.Options opts = createIoOptions(null, "polling");

Socket socket = IO.socket("http://127.0.0.1:" + port, opts);
try {
Expand Down Expand Up @@ -557,4 +496,13 @@ private static int awaitBoundPort(SocketIOServer server) throws InterruptedExcep
}
return port;
}
private IO.Options createIoOptions(OkHttpClient okHttp, String... transports) {
IO.Options opts = new IO.Options();
opts.forceNew = true;
opts.reconnection = false;
opts.transports = transports;
opts.webSocketFactory = okHttp;
opts.callFactory = okHttp;
return opts;
}
}
Loading