Skip to content

Potential fix for 1 code quality finding #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjomo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Potential fix for 1 code quality finding #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db451b8
Apply suggested fix to netty-socketio-core/src/test/java/com/socketio…
sanjomo May 21, 2026
2a311cb
Add findAvailablePort utility for tests
sanjomo May 21, 2026
4b63344
Merge branch 'main' into ai-findings-autofix/netty-socketio-core-src-…
sanjomo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...c/test/java/com/socketio4j/socketio/integration/DistributedClusterIntegrationSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package com.socketio4j.socketio.integration;

import java.net.ServerSocket;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
Expand All @@ -35,7 +36,11 @@ final class DistributedClusterIntegrationSupport {

private DistributedClusterIntegrationSupport() {
}

static int findAvailablePort() throws Exception {
try (ServerSocket socket = new ServerSocket(0)) {
return socket.getLocalPort();
}
}
static void applyReuseListenAddress(Configuration configuration) {
configuration.getSocketConfig().setReuseAddress(true);
}
Expand Down
10 changes: 2 additions & 8 deletions ...re/src/test/java/com/socketio4j/socketio/integration/DistributedRedissonClusterSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package com.socketio4j.socketio.integration;

import java.net.ServerSocket;

import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Nested;
Expand All @@ -34,6 +32,8 @@
import com.socketio4j.socketio.store.redis_reliable.RedisPubSubReliableEventStore;
import com.socketio4j.socketio.store.redis_stream.RedisStreamEventStore;

import static com.socketio4j.socketio.integration.DistributedClusterIntegrationSupport.findAvailablePort;

/**
* Runs {@link DistributedCommonTest} against all Redisson-backed cluster variants while sharing
* one Redis Testcontainer.
Expand All @@ -43,12 +43,6 @@ public class DistributedRedissonClusterSuite {
@SuppressWarnings("resource")
static final CustomizedRedisContainer REDIS = new CustomizedRedisContainer().withReuse(false);

private static int findAvailablePort() throws Exception {
try (ServerSocket socket = new ServerSocket(0)) {
return socket.getLocalPort();
}
}

@BeforeAll
static void startRedis() {
REDIS.start();
Expand Down
Loading