Skip to content

Use default prior_influence=0.0 for AADForest#337

Draft
matwey wants to merge 11 commits into
masterfrom
prior_influence
Draft

Use default prior_influence=0.0 for AADForest#337
matwey wants to merge 11 commits into
masterfrom
prior_influence

Conversation

@matwey

@matwey matwey commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

After discussions with Emille, Maria and Sreevarsha, it was found that 0.0 is better default.

@matwey matwey requested a review from hombit as a code owner June 3, 2026 08:07
@matwey

matwey commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@hombit I cannot reproduce the CI issue at the COIN server. What do you think could be wrong?

@codspeed-hq

codspeed-hq Bot commented Jun 3, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 45.98%

⚡ 1 improved benchmark
✅ 46 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmark_fit_known 117 ms 80.2 ms +45.98%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing prior_influence (61d5ca3) with master (39106f9)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@hombit hombit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it does look ok, but I cannot reproduce the numbers in your tests on both Mac and Linux ARM machines.

@matwey

matwey commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I don't like this PR in the current state. We need reproducible results.

@matwey matwey force-pushed the prior_influence branch 2 times, most recently from f87615b to c4cb0c0 Compare June 10, 2026 07:34
After discussions with Emille, Maria and Sreevarsha,
it was found that 0.0 is better default.
@matwey matwey force-pushed the prior_influence branch from ec89617 to 7a1bc20 Compare June 10, 2026 07:51
@matwey matwey marked this pull request as draft June 10, 2026 08:45
@matwey

matwey commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

#340 has to be resolved first

@matwey matwey force-pushed the prior_influence branch from 988b659 to 61d5ca3 Compare June 17, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants