Fix standalone BOLT12 offer payments#287
Merged
Merged
Conversation
Recognize checksum-less offers across raw, prefixed, continued, and BIP-321 send destinations with regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The send destination gate only recognized BOLT11, Ark, on-chain, and Lightning Address inputs. The existing BIP-321 dependency also validates BOLT12 offers as checksummed Bech32, while real BOLT12 offers use checksum-less Bech32, so valid offers were discarded before reaching the existing native payment path.
User impact
Users can paste or scan valid lno1 offers and proceed through amount entry and confirmation instead of receiving the invalid-destination popup.
Validation