(widgets): Accept numpad Enter to confirm entry edits#48
Merged
smolBlackCat merged 1 commit intoJun 27, 2026
Merged
Conversation
The inline-edit Entry widgets (card title, list header, task) only handled GDK_KEY_Return, so users pressing Enter on the numpad (which sends GDK_KEY_KP_Enter) had no effect. Add the keypad variant to the same case so both Enter keys confirm the edit. Co-authored-by: openhands <openhands@all-hands.dev>
smolBlackCat
approved these changes
Jun 27, 2026
smolBlackCat
left a comment
smolBlackCat
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution! I didn't know about this one constant, thank you very much for the insight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inline-edit Gtk::Entry widgets (card title, list header, task) only
handled GDK_KEY_Return, so users pressing Enter on the numpad (which
sends GDK_KEY_KP_Enter) had no effect. This adds the keypad variant to
the same case so both Enter keys confirm the edit.
Changes
The modal dialogs (board-dialog, card-dialog) use Gtk::Entry's default
activate signal, which already handles both Enter keys, so they are
not affected.
Testing
Built locally with cmake --build build (all 72 targets compile) and
ctest passes (5/5 existing tests).
AI
Harness: OpenHands
Model: openrouter/minimax/minimax-m3:zdr