feat(node-http-handler): pass client logger to request handlers#2170
Draft
aBurmeseDev wants to merge 3 commits into
Draft
feat(node-http-handler): pass client logger to request handlers#2170aBurmeseDev wants to merge 3 commits into
aBurmeseDev wants to merge 3 commits into
Conversation
TypeScript strict mode cannot narrow `value` from the full `NodeHttpHandlerOptions[typeof key]` union when branching on `key === "logger"`. Add an explicit cast to fix the build:types target in CI.
aBurmeseDev
marked this pull request as draft
July 23, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#6130
JS-7027
Description of changes:
getHttpHandlerExtensionConfig, routing handler-emitted warnings through customer's logger instead ofconsole.warnupdateHttpClientConfiguses nullish assignment for theloggerkey so an explicitly-set handler logger is never overwrittenNoOpLoggerto preserve the existing console fallback for those who doesn't have a logger configuredTesting
getHttpHandlerExtensionConfigNodeHttpHandler.updateHttpClientConfignullishUndiciHttpHandler.updateHttpClientConfigBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.